* [PATCH] fs: btrfs: Replace -ENOENT by -ERANGE in btrfs_get_acl()
@ 2016-07-03 4:40 Salah Triki
2016-07-04 17:53 ` David Sterba
0 siblings, 1 reply; 2+ messages in thread
From: Salah Triki @ 2016-07-03 4:40 UTC (permalink / raw)
To: clm, jbacik, dsterba; +Cc: linux-btrfs, linux-kernel, salah.triki
size contains the value returned by posix_acl_from_xattr(), which
returns -ERANGE, -ENODATA, zero, or an integer greater than zero. So
replace -ENOENT by -ERANGE.
Signed-off-by: Salah Triki <salah.triki@gmail.com>
---
fs/btrfs/acl.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/btrfs/acl.c b/fs/btrfs/acl.c
index 67a6077..53bb7af 100644
--- a/fs/btrfs/acl.c
+++ b/fs/btrfs/acl.c
@@ -55,8 +55,7 @@ struct posix_acl *btrfs_get_acl(struct inode *inode, int type)
}
if (size > 0) {
acl = posix_acl_from_xattr(&init_user_ns, value, size);
- } else if (size == -ENOENT || size == -ENODATA || size == 0) {
- /* FIXME, who returns -ENOENT? I think nobody */
+ } else if (size == -ERANGE || size == -ENODATA || size == 0) {
acl = NULL;
} else {
acl = ERR_PTR(-EIO);
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] fs: btrfs: Replace -ENOENT by -ERANGE in btrfs_get_acl()
2016-07-03 4:40 [PATCH] fs: btrfs: Replace -ENOENT by -ERANGE in btrfs_get_acl() Salah Triki
@ 2016-07-04 17:53 ` David Sterba
0 siblings, 0 replies; 2+ messages in thread
From: David Sterba @ 2016-07-04 17:53 UTC (permalink / raw)
To: Salah Triki; +Cc: clm, jbacik, dsterba, linux-btrfs, linux-kernel
On Sun, Jul 03, 2016 at 05:40:10AM +0100, Salah Triki wrote:
> size contains the value returned by posix_acl_from_xattr(), which
> returns -ERANGE, -ENODATA, zero, or an integer greater than zero. So
> replace -ENOENT by -ERANGE.
>
> Signed-off-by: Salah Triki <salah.triki@gmail.com>
Reviewed-by: David Sterba <dsterba@suse.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-07-04 17:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-03 4:40 [PATCH] fs: btrfs: Replace -ENOENT by -ERANGE in btrfs_get_acl() Salah Triki
2016-07-04 17:53 ` David Sterba
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).