* [PATCH] btrfs-progs: use the correct struct for BTRFS_IOC_LOGICAL_INO
@ 2016-07-03 21:22 Hans van Kranenburg
2016-07-04 12:13 ` David Sterba
0 siblings, 1 reply; 3+ messages in thread
From: Hans van Kranenburg @ 2016-07-03 21:22 UTC (permalink / raw)
To: linux-btrfs; +Cc: Hans van Kranenburg
BTRFS_IOC_LOGICAL_INO takes a btrfs_ioctl_logical_ino_args as argument,
not a btrfs_ioctl_ino_path_args. The lines were probably copy/pasted
when the code was written.
Since btrfs_ioctl_logical_ino_args and btrfs_ioctl_ino_path_args have
the same size, the actual IOCTL definition here does not change.
But, it makes the code less confusing for the reader.
Signed-off-by: Hans van Kranenburg <hans.van.kranenburg@mendix.com>
---
ioctl.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ioctl.h b/ioctl.h
index 5f18bcb..620dd3d 100644
--- a/ioctl.h
+++ b/ioctl.h
@@ -685,7 +685,7 @@ static inline char *btrfs_err_str(enum btrfs_err_code err_code)
#define BTRFS_IOC_INO_PATHS _IOWR(BTRFS_IOCTL_MAGIC, 35, \
struct btrfs_ioctl_ino_path_args)
#define BTRFS_IOC_LOGICAL_INO _IOWR(BTRFS_IOCTL_MAGIC, 36, \
- struct btrfs_ioctl_ino_path_args)
+ struct btrfs_ioctl_logical_ino_args)
#define BTRFS_IOC_SET_RECEIVED_SUBVOL _IOWR(BTRFS_IOCTL_MAGIC, 37, \
struct btrfs_ioctl_received_subvol_args)
#define BTRFS_IOC_SEND _IOW(BTRFS_IOCTL_MAGIC, 38, struct btrfs_ioctl_send_args)
--
2.8.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] btrfs-progs: use the correct struct for BTRFS_IOC_LOGICAL_INO
2016-07-03 21:22 [PATCH] btrfs-progs: use the correct struct for BTRFS_IOC_LOGICAL_INO Hans van Kranenburg
@ 2016-07-04 12:13 ` David Sterba
2016-07-04 12:14 ` David Sterba
0 siblings, 1 reply; 3+ messages in thread
From: David Sterba @ 2016-07-04 12:13 UTC (permalink / raw)
To: Hans van Kranenburg; +Cc: linux-btrfs
On Sun, Jul 03, 2016 at 11:22:26PM +0200, Hans van Kranenburg wrote:
> BTRFS_IOC_LOGICAL_INO takes a btrfs_ioctl_logical_ino_args as argument,
> not a btrfs_ioctl_ino_path_args. The lines were probably copy/pasted
> when the code was written.
>
> Since btrfs_ioctl_logical_ino_args and btrfs_ioctl_ino_path_args have
> the same size, the actual IOCTL definition here does not change.
>
> But, it makes the code less confusing for the reader.
>
> Signed-off-by: Hans van Kranenburg <hans.van.kranenburg@mendix.com>
Applied, thanks. Same fix is needed for kernel, care to send a patch?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] btrfs-progs: use the correct struct for BTRFS_IOC_LOGICAL_INO
2016-07-04 12:13 ` David Sterba
@ 2016-07-04 12:14 ` David Sterba
0 siblings, 0 replies; 3+ messages in thread
From: David Sterba @ 2016-07-04 12:14 UTC (permalink / raw)
To: dsterba, Hans van Kranenburg, linux-btrfs
On Mon, Jul 04, 2016 at 02:13:18PM +0200, David Sterba wrote:
> On Sun, Jul 03, 2016 at 11:22:26PM +0200, Hans van Kranenburg wrote:
> > BTRFS_IOC_LOGICAL_INO takes a btrfs_ioctl_logical_ino_args as argument,
> > not a btrfs_ioctl_ino_path_args. The lines were probably copy/pasted
> > when the code was written.
> >
> > Since btrfs_ioctl_logical_ino_args and btrfs_ioctl_ino_path_args have
> > the same size, the actual IOCTL definition here does not change.
> >
> > But, it makes the code less confusing for the reader.
> >
> > Signed-off-by: Hans van Kranenburg <hans.van.kranenburg@mendix.com>
>
> Applied, thanks. Same fix is needed for kernel, care to send a patch?
Apparenly you did that, sorry.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-07-04 12:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-03 21:22 [PATCH] btrfs-progs: use the correct struct for BTRFS_IOC_LOGICAL_INO Hans van Kranenburg
2016-07-04 12:13 ` David Sterba
2016-07-04 12:14 ` David Sterba
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).