From: David Sterba <dsterba@suse.com>
To: linux-btrfs@vger.kernel.org
Cc: David Sterba <dsterba@suse.com>
Subject: [PATCH 09/13] btrfs-progs: document all btrfs_open_ctree_flags
Date: Tue, 23 Aug 2016 12:25:13 +0200 [thread overview]
Message-ID: <1471947917-5324-10-git-send-email-dsterba@suse.com> (raw)
In-Reply-To: <1471947917-5324-1-git-send-email-dsterba@suse.com>
Document and add unsigned type to the values.
Signed-off-by: David Sterba <dsterba@suse.com>
---
disk-io.h | 41 +++++++++++++++++++++++++----------------
1 file changed, 25 insertions(+), 16 deletions(-)
diff --git a/disk-io.h b/disk-io.h
index a73dede1e8d0..c404d3f4fdfe 100644
--- a/disk-io.h
+++ b/disk-io.h
@@ -29,21 +29,29 @@
#define BTRFS_SUPER_MIRROR_SHIFT 12
enum btrfs_open_ctree_flags {
- OPEN_CTREE_WRITES = (1 << 0),
- OPEN_CTREE_PARTIAL = (1 << 1),
- OPEN_CTREE_BACKUP_ROOT = (1 << 2),
- OPEN_CTREE_RECOVER_SUPER = (1 << 3),
- OPEN_CTREE_RESTORE = (1 << 4),
- OPEN_CTREE_NO_BLOCK_GROUPS = (1 << 5),
- OPEN_CTREE_EXCLUSIVE = (1 << 6),
- OPEN_CTREE_NO_DEVICES = (1 << 7),
+ /* Open filesystem for writes */
+ OPEN_CTREE_WRITES = (1U << 0),
+ /* Allow to open filesystem with some broken tree roots (eg log root) */
+ OPEN_CTREE_PARTIAL = (1U << 1),
+ /* If primary root pinters are invalid, try backup copies */
+ OPEN_CTREE_BACKUP_ROOT = (1U << 2),
+ /* Allow reading all superblock sopies if the primary is damaged */
+ OPEN_CTREE_RECOVER_SUPER = (1U << 3),
+ /* Restoring filesystem image */
+ OPEN_CTREE_RESTORE = (1U << 4),
+ /* Do not read block groups (extent tree) */
+ OPEN_CTREE_NO_BLOCK_GROUPS = (1U << 5),
+ /* Open all devices in O_EXCL mode */
+ OPEN_CTREE_EXCLUSIVE = (1U << 6),
+ /* Do not scan devices */
+ OPEN_CTREE_NO_DEVICES = (1U << 7),
/*
* Don't print error messages if bytenr or checksums do not match in
* tree block headers. Turn on by OPEN_CTREE_SUPPRESS_ERROR
*/
- OPEN_CTREE_SUPPRESS_CHECK_BLOCK_ERRORS = (1 << 8),
- /* Return chunk root */
- __OPEN_CTREE_RETURN_CHUNK_ROOT = (1 << 9),
+ OPEN_CTREE_SUPPRESS_CHECK_BLOCK_ERRORS = (1U << 8),
+ /* Return the chunk root */
+ __OPEN_CTREE_RETURN_CHUNK_ROOT = (1U << 9),
OPEN_CTREE_CHUNK_ROOT_ONLY = OPEN_CTREE_PARTIAL +
OPEN_CTREE_SUPPRESS_CHECK_BLOCK_ERRORS +
__OPEN_CTREE_RETURN_CHUNK_ROOT,
@@ -53,18 +61,19 @@ enum btrfs_open_ctree_flags {
* Like split PARTIAL into SKIP_CSUM/SKIP_EXTENT
*/
- OPEN_CTREE_IGNORE_FSID_MISMATCH = (1 << 10),
+ /* Ignore UUID mismatches */
+ OPEN_CTREE_IGNORE_FSID_MISMATCH = (1U << 10),
/*
- * Allow open_ctree_fs_info() to return a incomplete fs_info with
+ * Allow open_ctree_fs_info() to return an incomplete fs_info with
* system chunks from super block only.
- * It's useful for chunk corruption case.
+ * It's useful when chunks are corrupted.
* Makes no sense for open_ctree variants returning btrfs_root.
*/
- OPEN_CTREE_IGNORE_CHUNK_TREE_ERROR = (1 << 11),
+ OPEN_CTREE_IGNORE_CHUNK_TREE_ERROR = (1U << 11),
/* Allow to open a partially created filesystem */
- OPEN_CTREE_FS_PARTIAL = (1 << 12),
+ OPEN_CTREE_FS_PARTIAL = (1U << 12),
};
/*
--
2.7.1
next prev parent reply other threads:[~2016-08-23 10:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-23 10:25 [PATCH 00/13] Btrfs-progs: partial mkfs/convert, error handling, cleanups David Sterba
2016-08-23 10:25 ` [PATCH 01/13] btrfs-progs: pass OPEN_CTREE flags as unsigned David Sterba
2016-08-24 10:24 ` Anand Jain
2016-08-23 10:25 ` [PATCH 02/13] btrfs-progs: make superblock reading/scanning api more generic David Sterba
2016-08-23 10:25 ` [PATCH 03/13] btrfs-progs: introduce signature for a partially set up filesystem David Sterba
2016-08-23 10:25 ` [PATCH 04/13] btrfs-progs: mkfs: do not scan partially initialized devices David Sterba
2016-08-23 10:25 ` [PATCH 05/13] btrfs-progs: two staged filesystem creation David Sterba
2016-08-24 10:27 ` Anand Jain
2016-08-23 10:25 ` [PATCH 06/13] btrfs-progs: mkfs: return errors from block group creation functions David Sterba
2016-08-23 10:25 ` [PATCH 07/13] btrfs-progs: mkfs: improve error handling in main() David Sterba
2016-08-23 10:25 ` [PATCH 08/13] btrfs-progs: mkfs: improve error handling in recow_roots David Sterba
2016-08-23 10:25 ` David Sterba [this message]
2016-08-23 10:25 ` [PATCH 10/13] btrfs-progs: mkfs: switch BUG_ON to error handling in traverse_directory David Sterba
2016-08-23 10:25 ` [PATCH 11/13] btrfs-progs: mkfs: handle and report transaction commit failures David Sterba
2016-08-23 10:25 ` [PATCH 12/13] btrfs-progs: mkfs: help and usage now to to stdout David Sterba
2016-08-23 10:25 ` [PATCH 13/13] btrfs-progs: mkfs: clean up make_image David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1471947917-5324-10-git-send-email-dsterba@suse.com \
--to=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).