From: Christoph Anton Mitterer <calestyo@scientia.net>
To: Qu Wenruo <quwenruo@cn.fujitsu.com>, linux-btrfs@vger.kernel.org
Subject: Re: does btrfs-receive use/compare the checksums from the btrfs-send side?
Date: Sun, 04 Sep 2016 06:29:21 +0200 [thread overview]
Message-ID: <1472963361.8683.14.camel@scientia.net> (raw)
In-Reply-To: <640da4f0-4854-5135-aacc-350bfa99c6ed@cn.fujitsu.com>
[-- Attachment #1: Type: text/plain, Size: 1141 bytes --]
On Mon, 2016-08-29 at 16:25 +0800, Qu Wenruo wrote:
> Send will generate checksum for each command.
What does "command" mean here? Or better said how much data is secured
with one CRC32?
> For send stream, it's CRC32 for the whole command.
And this is verified then on the receiving end?
Wouldn't it be useful (if this technically possibly) to use the
checksums directly from the sent blocks? That way one could also catch
any errors on the receiving side, that occurred after the checksum from
the receive was verified (e.g. memory errors).
And couldn't one do something similar locally, when btrfs copies
blocks?
At least something like this would seem to me like the most native way:
- One want's checksum protection
- One copies data
- One has already checksums for that data
=> thus that should be used, as it's the most canonical version of a
checksum for that data... anything that is newly calculated could
in the best case just be good, and in the worst add new errors
(unnoticed),... e.g. when memory is broken and the new checksum is
calculated over that.
Cheers,
Chris.
[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5930 bytes --]
next prev parent reply other threads:[~2016-09-04 4:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-28 3:46 does btrfs-receive use/compare the checksums from the btrfs-send side? Christoph Anton Mitterer
2016-08-28 17:35 ` Chris Murphy
2016-08-28 17:50 ` Christoph Anton Mitterer
2016-08-28 20:19 ` Adam Borowski
2016-08-28 20:25 ` Christoph Anton Mitterer
2016-08-30 17:14 ` Sean Greenslade
2016-08-29 8:25 ` Qu Wenruo
2016-09-04 4:29 ` Christoph Anton Mitterer [this message]
2016-09-05 7:45 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1472963361.8683.14.camel@scientia.net \
--to=calestyo@scientia.net \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).