* [PATCH] btrfs: change btrfs_csum_final result param type to u8 @ 2016-09-17 23:10 Domagoj Tršan 2016-09-17 23:10 ` Domagoj Tršan 2016-09-19 17:22 ` David Sterba 0 siblings, 2 replies; 5+ messages in thread From: Domagoj Tršan @ 2016-09-17 23:10 UTC (permalink / raw) To: linux-btrfs; +Cc: clm, jbacik, dsterba, Domagoj Tršan csum member of struct btrfs_super_block has array type of u8. It makes sense that function btrfs_csum_final should be also declared to accept u8 *. I changed the declaration of method void btrfs_csum_final(u32 crc, char *result); to void btrfs_csum_final(u32 crc, u8 *result); Domagoj Tršan (1): btrfs: change btrfs_csum_final result param type to u8 fs/btrfs/disk-io.c | 2 +- fs/btrfs/disk-io.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) -- 2.7.4 ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] btrfs: change btrfs_csum_final result param type to u8 2016-09-17 23:10 [PATCH] btrfs: change btrfs_csum_final result param type to u8 Domagoj Tršan @ 2016-09-17 23:10 ` Domagoj Tršan 2016-09-19 17:22 ` David Sterba 1 sibling, 0 replies; 5+ messages in thread From: Domagoj Tršan @ 2016-09-17 23:10 UTC (permalink / raw) To: linux-btrfs; +Cc: clm, jbacik, dsterba, Domagoj Tršan --- fs/btrfs/disk-io.c | 2 +- fs/btrfs/disk-io.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c index 50bed6c..95bd34f 100644 --- a/fs/btrfs/disk-io.c +++ b/fs/btrfs/disk-io.c @@ -273,7 +273,7 @@ u32 btrfs_csum_data(char *data, u32 seed, size_t len) return btrfs_crc32c(seed, data, len); } -void btrfs_csum_final(u32 crc, char *result) +void btrfs_csum_final(u32 crc, u8 *result) { put_unaligned_le32(~crc, result); } diff --git a/fs/btrfs/disk-io.h b/fs/btrfs/disk-io.h index 8e79d00..e849845 100644 --- a/fs/btrfs/disk-io.h +++ b/fs/btrfs/disk-io.h @@ -118,7 +118,7 @@ int btrfs_buffer_uptodate(struct extent_buffer *buf, u64 parent_transid, int atomic); int btrfs_read_buffer(struct extent_buffer *buf, u64 parent_transid); u32 btrfs_csum_data(char *data, u32 seed, size_t len); -void btrfs_csum_final(u32 crc, char *result); +void btrfs_csum_final(u32 crc, u8 *result); int btrfs_bio_wq_end_io(struct btrfs_fs_info *info, struct bio *bio, enum btrfs_wq_endio_type metadata); int btrfs_wq_submit_bio(struct btrfs_fs_info *fs_info, struct inode *inode, -- 2.7.4 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] btrfs: change btrfs_csum_final result param type to u8 2016-09-17 23:10 [PATCH] btrfs: change btrfs_csum_final result param type to u8 Domagoj Tršan 2016-09-17 23:10 ` Domagoj Tršan @ 2016-09-19 17:22 ` David Sterba 2016-10-12 14:43 ` David Sterba 1 sibling, 1 reply; 5+ messages in thread From: David Sterba @ 2016-09-19 17:22 UTC (permalink / raw) To: Domagoj Tršan; +Cc: linux-btrfs, clm, jbacik, dsterba On Sun, Sep 18, 2016 at 12:10:34AM +0100, Domagoj Tršan wrote: > csum member of struct btrfs_super_block has array type of u8. It makes sense > that function btrfs_csum_final should be also declared to accept u8 *. I > changed the declaration of method void btrfs_csum_final(u32 crc, char *result); > to void btrfs_csum_final(u32 crc, u8 *result); You should put a similar text to the patch itself, it's not necessary to send the cover letter for single patches. Otherwise the change is ok. ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] btrfs: change btrfs_csum_final result param type to u8 2016-09-19 17:22 ` David Sterba @ 2016-10-12 14:43 ` David Sterba 2016-10-21 11:51 ` Domagoj Tršan 0 siblings, 1 reply; 5+ messages in thread From: David Sterba @ 2016-10-12 14:43 UTC (permalink / raw) To: Domagoj Tršan; +Cc: linux-btrfs, clm, jbacik, dsterba On Mon, Sep 19, 2016 at 07:22:28PM +0200, David Sterba wrote: > On Sun, Sep 18, 2016 at 12:10:34AM +0100, Domagoj Tršan wrote: > > csum member of struct btrfs_super_block has array type of u8. It makes sense > > that function btrfs_csum_final should be also declared to accept u8 *. I > > changed the declaration of method void btrfs_csum_final(u32 crc, char *result); > > to void btrfs_csum_final(u32 crc, u8 *result); > > You should put a similar text to the patch itself, it's not necessary to > send the cover letter for single patches. Otherwise the change is ok. Please update the patch according to the above and resend. ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] btrfs: change btrfs_csum_final result param type to u8 2016-10-12 14:43 ` David Sterba @ 2016-10-21 11:51 ` Domagoj Tršan 0 siblings, 0 replies; 5+ messages in thread From: Domagoj Tršan @ 2016-10-21 11:51 UTC (permalink / raw) To: dsterba, linux-btrfs, clm, jbacik, dsterba On 2016-10-12 16:43 +0200, David Sterba wrote: > On Mon, Sep 19, 2016 at 07:22:28PM +0200, David Sterba wrote: > > On Sun, Sep 18, 2016 at 12:10:34AM +0100, Domagoj Tršan wrote: > > > csum member of struct btrfs_super_block has array type of u8. It makes sense > > > that function btrfs_csum_final should be also declared to accept u8 *. I > > > changed the declaration of method void btrfs_csum_final(u32 crc, char *result); > > > to void btrfs_csum_final(u32 crc, u8 *result); > > > > You should put a similar text to the patch itself, it's not necessary to > > send the cover letter for single patches. Otherwise the change is ok. > > Please update the patch according to the above and resend. Hi David, apologies for the delay. I sent the new version patch. Cheers! -- (\/)(;,,;)(\/) ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-10-21 11:51 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-09-17 23:10 [PATCH] btrfs: change btrfs_csum_final result param type to u8 Domagoj Tršan 2016-09-17 23:10 ` Domagoj Tršan 2016-09-19 17:22 ` David Sterba 2016-10-12 14:43 ` David Sterba 2016-10-21 11:51 ` Domagoj Tršan
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).