From: jeffm@suse.com
To: linux-btrfs@vger.kernel.org
Cc: David Sterba <dsterba@suse.com>
Subject: [PATCH 0/5] btrfs: printing cleanup patchset
Date: Tue, 20 Sep 2016 10:04:58 -0400 [thread overview]
Message-ID: <1474380303-25995-1-git-send-email-jeffm@suse.com> (raw)
From: Jeff Mahoney <jeffm@suse.com>
This is a patchset I've been working on to clean up message printing,
make it adhere to kernel style, and be more consistent.
The end result is that we:
* use dynamic debugging for debugging messages
* merge strings that exceed 80 characters into a single greppable string
* convert printk calls to btrfs_{warn,info,err,debug,etc} calls where it
makes sense.
* dump the ad-hoc verbose_printk garbage in send
The exception to this is check-integrity since it has a ton of messages
and it also has its own mask mechanism. I wanted to discuss if we wanted
to find another solution to that and, if so, how we want to move forward
there.
Dave, this will probably conflict with the fsinfo patchset, so please
advise on which you want to land first.
-Jeff
Jeff Mahoney (5):
btrfs: add dynamic debug support
btrfs: unsplit printed strings
btrfs: convert printk(KERN_* to use pr_* calls
btrfs: convert pr_* to btrfs_* where possible
btrfs: convert send's verbose_printk to btrfs_debug
fs/btrfs/backref.c | 48 ++++---
fs/btrfs/check-integrity.c | 335 ++++++++++++++------------------------------
fs/btrfs/compression.c | 6 +-
fs/btrfs/ctree.c | 12 +-
fs/btrfs/ctree.h | 39 +++++-
fs/btrfs/delayed-inode.c | 17 +--
fs/btrfs/delayed-ref.c | 9 +-
fs/btrfs/dev-replace.c | 21 +--
fs/btrfs/dir-item.c | 7 +-
fs/btrfs/disk-io.c | 98 ++++++-------
fs/btrfs/extent-tree.c | 106 +++++++-------
fs/btrfs/extent_io.c | 93 ++++++------
fs/btrfs/free-space-cache.c | 21 +--
fs/btrfs/free-space-cache.h | 6 +-
fs/btrfs/free-space-tree.c | 14 +-
fs/btrfs/inode-map.c | 31 ++--
fs/btrfs/inode.c | 26 ++--
fs/btrfs/ioctl.c | 14 +-
fs/btrfs/lzo.c | 6 +-
fs/btrfs/ordered-data.c | 4 +-
fs/btrfs/print-tree.c | 86 +++++-------
fs/btrfs/qgroup.c | 22 +--
fs/btrfs/reada.c | 32 ++---
fs/btrfs/relocation.c | 16 ++-
fs/btrfs/root-tree.c | 18 +--
fs/btrfs/scrub.c | 58 ++++----
fs/btrfs/send.c | 71 +++++-----
fs/btrfs/super.c | 60 ++++----
fs/btrfs/sysfs.c | 8 +-
fs/btrfs/transaction.c | 20 +--
fs/btrfs/transaction.h | 1 +
fs/btrfs/tree-log.c | 8 +-
fs/btrfs/uuid-tree.c | 27 ++--
fs/btrfs/volumes.c | 131 +++++++++--------
fs/btrfs/volumes.h | 2 +-
fs/btrfs/zlib.c | 8 +-
36 files changed, 719 insertions(+), 762 deletions(-)
--
2.7.1
next reply other threads:[~2016-09-20 14:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-20 14:04 jeffm [this message]
2016-09-20 14:04 ` [PATCH 1/5] btrfs: add dynamic debug support jeffm
2016-09-20 14:05 ` [PATCH 2/5] btrfs: unsplit printed strings jeffm
2016-09-20 14:05 ` [PATCH 3/5] btrfs: convert printk(KERN_* to use pr_* calls jeffm
2016-09-20 14:05 ` [PATCH 4/5] btrfs: convert pr_* to btrfs_* where possible jeffm
2016-09-21 15:36 ` David Sterba
2016-09-23 12:37 ` David Sterba
2016-09-20 14:05 ` [PATCH 5/5] btrfs: convert send's verbose_printk to btrfs_debug jeffm
2016-09-21 15:43 ` [PATCH] btrfs: silence compiler warning when fs_info is not used David Sterba
2016-09-21 15:47 ` Jeff Mahoney
2016-09-21 16:16 ` Jeff Mahoney
2016-09-21 15:46 ` [PATCH 0/5] btrfs: printing cleanup patchset David Sterba
2016-09-21 16:17 ` [PATCH] btrfs: btrfs_debug should consume fs_info when DEBUG is not defined Jeff Mahoney
2016-09-22 14:43 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1474380303-25995-1-git-send-email-jeffm@suse.com \
--to=jeffm@suse.com \
--cc=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).