linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH 2/9] btrfs: don't access the bio directly in the raid5/6 code
Date: Wed, 16 Nov 2016 13:52:09 +0100	[thread overview]
Message-ID: <1479300736-9724-3-git-send-email-hch@lst.de> (raw)
In-Reply-To: <1479300736-9724-1-git-send-email-hch@lst.de>

Just use bio_for_each_segment_all to iterate over all segments.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 fs/btrfs/raid56.c | 16 ++++++----------
 1 file changed, 6 insertions(+), 10 deletions(-)

diff --git a/fs/btrfs/raid56.c b/fs/btrfs/raid56.c
index d016d4a..da941fb 100644
--- a/fs/btrfs/raid56.c
+++ b/fs/btrfs/raid56.c
@@ -1144,10 +1144,10 @@ static void validate_rbio_for_rmw(struct btrfs_raid_bio *rbio)
 static void index_rbio_pages(struct btrfs_raid_bio *rbio)
 {
 	struct bio *bio;
+	struct bio_vec *bvec;
 	u64 start;
 	unsigned long stripe_offset;
 	unsigned long page_index;
-	struct page *p;
 	int i;
 
 	spin_lock_irq(&rbio->bio_list_lock);
@@ -1156,10 +1156,8 @@ static void index_rbio_pages(struct btrfs_raid_bio *rbio)
 		stripe_offset = start - rbio->bbio->raid_map[0];
 		page_index = stripe_offset >> PAGE_SHIFT;
 
-		for (i = 0; i < bio->bi_vcnt; i++) {
-			p = bio->bi_io_vec[i].bv_page;
-			rbio->bio_pages[page_index + i] = p;
-		}
+		bio_for_each_segment_all(bvec, bio, i)
+			rbio->bio_pages[page_index+ i] = bvec->bv_page;
 	}
 	spin_unlock_irq(&rbio->bio_list_lock);
 }
@@ -1433,13 +1431,11 @@ static int fail_bio_stripe(struct btrfs_raid_bio *rbio,
  */
 static void set_bio_pages_uptodate(struct bio *bio)
 {
+	struct bio_vec *bvec;
 	int i;
-	struct page *p;
 
-	for (i = 0; i < bio->bi_vcnt; i++) {
-		p = bio->bi_io_vec[i].bv_page;
-		SetPageUptodate(p);
-	}
+	bio_for_each_segment_all(bvec, bio, i)
+		SetPageUptodate(bvec->bv_page);
 }
 
 /*
-- 
2.1.4


  parent reply	other threads:[~2016-11-16 12:52 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-16 12:52 don't poke into bio internals Christoph Hellwig
2016-11-16 12:52 ` [PATCH 1/9] btrfs: use bio iterators for the decompression handlers Christoph Hellwig
2016-11-19  1:29   ` Liu Bo
2016-11-22  9:38     ` Christoph Hellwig
2016-11-22 20:32       ` Liu Bo
2016-11-16 12:52 ` Christoph Hellwig [this message]
2016-11-18 19:05   ` [PATCH 2/9] btrfs: don't access the bio directly in the raid5/6 code Omar Sandoval
2016-11-16 12:52 ` [PATCH 3/9] " Christoph Hellwig
2016-11-18 19:34   ` Omar Sandoval
2016-11-16 12:52 ` [PATCH 4/9] btrfs: don't access the bio directly in btrfs_csum_one_bio Christoph Hellwig
2016-11-18 19:39   ` Omar Sandoval
2016-11-16 12:52 ` [PATCH 5/9] btrfs: use bi_size Christoph Hellwig
2016-11-18 19:48   ` Omar Sandoval
2016-11-16 12:52 ` [PATCH 6/9] btrfs: calculate end of bio offset properly Christoph Hellwig
2016-11-18 20:04   ` Omar Sandoval
2016-11-22  9:42     ` Christoph Hellwig
2016-11-22 18:58       ` Omar Sandoval
2016-11-23  4:21         ` Anand Jain
2016-11-23  4:21           ` Omar Sandoval
2016-11-23  4:32             ` Anand Jain
2016-11-23  4:47               ` Omar Sandoval
2016-11-16 12:52 ` [PATCH 7/9] btrfs: refactor __btrfs_lookup_bio_sums to use bio_for_each_segment_all Christoph Hellwig
2016-11-18 20:31   ` Omar Sandoval
2016-11-16 12:52 ` [PATCH 8/9] btrfs: use bio_for_each_segment_all in __btrfsic_submit_bio Christoph Hellwig
2016-11-18 20:36   ` Omar Sandoval
2016-11-16 12:52 ` [PATCH 9/9] btrfs: only check bio size to see if a repair bio should have the failfast flag Christoph Hellwig
2016-11-16 16:19 ` don't poke into bio internals David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1479300736-9724-3-git-send-email-hch@lst.de \
    --to=hch@lst.de \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).