* [PATCH] Btrfs: remove rb_node field from the delayed ref node structure
@ 2016-11-18 9:38 fdmanana
2016-11-18 14:59 ` David Sterba
0 siblings, 1 reply; 2+ messages in thread
From: fdmanana @ 2016-11-18 9:38 UTC (permalink / raw)
To: linux-btrfs; +Cc: Filipe Manana
From: Filipe Manana <fdmanana@suse.com>
After the last big change in the delayed references code that was needed
for the last qgroups rework, the red black tree node field of struct
btrfs_delayed_ref_node is no longer used, so just remove it, this helps
us save some memory (since struct rb_node is 24 bytes on x86_64) for
these structures.
Signed-off-by: Filipe Manana <fdmanana@suse.com>
---
fs/btrfs/delayed-ref.h | 6 ------
1 file changed, 6 deletions(-)
diff --git a/fs/btrfs/delayed-ref.h b/fs/btrfs/delayed-ref.h
index 43f3629..a72fbe7 100644
--- a/fs/btrfs/delayed-ref.h
+++ b/fs/btrfs/delayed-ref.h
@@ -34,12 +34,6 @@
* ref_head. Must clean this mess up later.
*/
struct btrfs_delayed_ref_node {
- /*
- * ref_head use rb tree, stored in ref_root->href.
- * indexed by bytenr
- */
- struct rb_node rb_node;
-
/*data/tree ref use list, stored in ref_head->ref_list. */
struct list_head list;
--
2.7.0.rc3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Btrfs: remove rb_node field from the delayed ref node structure
2016-11-18 9:38 [PATCH] Btrfs: remove rb_node field from the delayed ref node structure fdmanana
@ 2016-11-18 14:59 ` David Sterba
0 siblings, 0 replies; 2+ messages in thread
From: David Sterba @ 2016-11-18 14:59 UTC (permalink / raw)
To: fdmanana; +Cc: linux-btrfs, Filipe Manana
On Fri, Nov 18, 2016 at 09:38:44AM +0000, fdmanana@kernel.org wrote:
> From: Filipe Manana <fdmanana@suse.com>
>
> After the last big change in the delayed references code that was needed
> for the last qgroups rework, the red black tree node field of struct
> btrfs_delayed_ref_node is no longer used, so just remove it, this helps
> us save some memory (since struct rb_node is 24 bytes on x86_64) for
> these structures.
>
> Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-11-18 14:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-18 9:38 [PATCH] Btrfs: remove rb_node field from the delayed ref node structure fdmanana
2016-11-18 14:59 ` David Sterba
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).