Re: [PATCH v3 0/6] Btrfs: incremental send, fix serval case failure

Re: [PATCH v3 0/6] Btrfs: incremental send, fix serval case failure

[Giuseppe Della Bianca]

Hi.

This looks bit like at my issue with the differential sending/receiving
and snapshot deleting.

Thanks for the test cases and for the patches.


Regards. 

Gdb

>>robbieko Thu, 05 Jan 2017 00:47:54 -0800


>>From: Robbie Ko <robbi...@synology.com>

>>Patch for fix btrfs incremental send.
>>These patches base on v4.8.0-rc8
>>V3: Improve the change log
>>V2: Add a new patch "add generation check in existence demtermination for
    the parent directory"

>>Robbie Ko (6):
>>  Btrfs: incremental send, fix failure to rename with the name collision
>>  Btrfs: incremental send, fix invalid path for truncate operations
>>  Btrfs: incremental send, fix not necessary waiting for rmdir operation
>>  Btrfs: incremental send, fix invalid path for rmdir operations
>>  Btrfs: incremental send, fix invalid rename operations
>>  Btrfs: incremental send, fix invalid utime operations
]zac[

[PATCH v3 0/6] Btrfs: incremental send, fix serval case failure

[robbieko]

From: Robbie Ko <robbieko@synology.com>

Patch for fix btrfs incremental send.
These patches base on v4.8.0-rc8

V3: Improve the change log
V2: Add a new patch "add generation check in existence demtermination for
    the parent directory"

Robbie Ko (6):
  Btrfs: incremental send, fix failure to rename with the name collision
  Btrfs: incremental send, fix invalid path for truncate operations
  Btrfs: incremental send, fix not necessary waiting for rmdir operation
  Btrfs: incremental send, fix invalid path for rmdir operations
  Btrfs: incremental send, fix invalid rename operations
  Btrfs: incremental send, fix invalid utime operations

 fs/btrfs/send.c | 61 ++++++++++++++++++++++++++++++++++++++++++++-------------
 1 file changed, 47 insertions(+), 14 deletions(-)

-- 
1.9.1

Re: [PATCH v3 0/6] Btrfs: incremental send, fix serval case failure

[David Sterba]

On Thu, Jan 05, 2017 at 04:24:54PM +0800, robbieko wrote:
> From: Robbie Ko <robbieko@synology.com>
> 
> Patch for fix btrfs incremental send.
> These patches base on v4.8.0-rc8

Is this a typo or did you really base the patches on 4.8-rc8? At the
moment we're nearing the v4.11 development cycle, so patches should be
eg. based on a recent 4.10-rc from the master branch. Let me know
privately if you need more information on the development cycle and
workflow.

> V3: Improve the change log

Please take Filipe's advice and comments seriously. Changelogs are
important part of the patches, namely for fixes that are not obvious and
fix corner cases. Writing good changelogs takes time to learn, you can
find examples in the log of send.c .