From: Nikolay Borisov <nborisov@suse.com>
To: dsterba@suse.cz
Cc: jeffm@suse.com, linux-btrfs@vger.kernel.org,
Nikolay Borisov <nborisov@suse.com>
Subject: [PATCH] btrfs: round down size diff when shrinking/growing device
Date: Fri, 21 Jul 2017 11:28:24 +0300 [thread overview]
Message-ID: <1500625704-29861-1-git-send-email-nborisov@suse.com> (raw)
Further testing showed that the fix introduced in 7dfb8be11b5d
("btrfs: Round down values which are written for total_bytes_size") was
insufficient and it could still lead to discrepancies between the total_bytes in
the super block and the device total bytes. So this patch also ensures that
the difference between old/new sizes when shrinking/growing is also
rounded down. This ensure that we won't be substracting/adding a non-sectorsize
multiples to the superblock/device total sizees.
Fixes: 7dfb8be11b5d ("btrfs: Round down values which are written for total_bytes_size")
Signed-off-by: Nikolay Borisov <nborisov@suse.com>
---
fs/btrfs/volumes.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index fa779875bcfb..774b4168841a 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -2701,7 +2701,7 @@ int btrfs_grow_device(struct btrfs_trans_handle *trans,
mutex_lock(&fs_info->chunk_mutex);
old_total = btrfs_super_total_bytes(super_copy);
- diff = new_size - device->total_bytes;
+ diff = round_down(new_size - device->total_bytes, fs_info->sectorsize);
if (new_size <= device->total_bytes ||
device->is_tgtdev_for_dev_replace) {
@@ -4399,7 +4399,7 @@ int btrfs_shrink_device(struct btrfs_device *device, u64 new_size)
u64 diff;
new_size = round_down(new_size, fs_info->sectorsize);
- diff = old_size - new_size;
+ diff = round_down(old_size - new_size, fs_info->sectorsize);
if (device->is_tgtdev_for_dev_replace)
return -EINVAL;
--
2.7.4
next reply other threads:[~2017-07-21 8:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-21 8:28 Nikolay Borisov [this message]
2017-07-24 13:24 ` [PATCH] btrfs: round down size diff when shrinking/growing device David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1500625704-29861-1-git-send-email-nborisov@suse.com \
--to=nborisov@suse.com \
--cc=dsterba@suse.cz \
--cc=jeffm@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).