[PATCH] btrfs: Remove redundant setting of uuid in btrfs_block_header.

[PATCH] btrfs: Remove redundant setting of uuid in btrfs_block_header.

[Nikolay Borisov]

btrfs_alloc_dev_extent currently unconditionally sets the uuid in the leaf block
header the function is working with. This is unnecessary since this operation
is peformed by the core btree handling code (splitting a node, allocating a new
btree block etc). So let's remove it.

Signed-off-by: Nikolay Borisov <nborisov@suse.com>
---
 fs/btrfs/volumes.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index 5a1913956f20..84501e9d486c 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -1611,8 +1611,6 @@ static int btrfs_alloc_dev_extent(struct btrfs_trans_handle *trans,
 					    BTRFS_FIRST_CHUNK_TREE_OBJECTID);
 	btrfs_set_dev_extent_chunk_offset(leaf, extent, chunk_offset);
 
-	write_extent_buffer_chunk_tree_uuid(leaf, fs_info->chunk_tree_uuid);
-
 	btrfs_set_dev_extent_length(leaf, extent, num_bytes);
 	btrfs_mark_buffer_dirty(leaf);
 out:
-- 
2.7.4

Re: [PATCH] btrfs: Remove redundant setting of uuid in btrfs_block_header.

[David Sterba]

On Fri, Jul 28, 2017 at 10:50:14AM +0300, Nikolay Borisov wrote:
> btrfs_alloc_dev_extent currently unconditionally sets the uuid in the leaf block
> header the function is working with. This is unnecessary since this operation
> is peformed by the core btree handling code (splitting a node, allocating a new
> btree block etc). So let's remove it.
> 
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>

Reviewed-by: David Sterba <dsterba@suse.com>