* [PATCH] btrfs: Clean up unused variables in free-space-tree.c
@ 2017-10-12 21:40 Christos Gkekas
2017-10-12 21:43 ` Omar Sandoval
0 siblings, 1 reply; 3+ messages in thread
From: Christos Gkekas @ 2017-10-12 21:40 UTC (permalink / raw)
To: Chris Mason, Josef Bacik, David Sterba, linux-btrfs, linux-kernel
Cc: Christos Gkekas
Remove variables 'start' and 'end', which are set but never used.
Signed-off-by: Christos Gkekas <chris.gekas@gmail.com>
---
fs/btrfs/free-space-tree.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/fs/btrfs/free-space-tree.c b/fs/btrfs/free-space-tree.c
index 684f122..fe5e032 100644
--- a/fs/btrfs/free-space-tree.c
+++ b/fs/btrfs/free-space-tree.c
@@ -1286,12 +1286,8 @@ static int __add_block_group_free_space(struct btrfs_trans_handle *trans,
struct btrfs_block_group_cache *block_group,
struct btrfs_path *path)
{
- u64 start, end;
int ret;
- start = block_group->key.objectid;
- end = block_group->key.objectid + block_group->key.offset;
-
block_group->needs_free_space = 0;
ret = add_new_free_space_info(trans, fs_info, block_group, path);
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] btrfs: Clean up unused variables in free-space-tree.c
2017-10-12 21:40 [PATCH] btrfs: Clean up unused variables in free-space-tree.c Christos Gkekas
@ 2017-10-12 21:43 ` Omar Sandoval
2017-10-13 12:08 ` David Sterba
0 siblings, 1 reply; 3+ messages in thread
From: Omar Sandoval @ 2017-10-12 21:43 UTC (permalink / raw)
To: Christos Gkekas
Cc: Chris Mason, Josef Bacik, David Sterba, linux-btrfs, linux-kernel
On Thu, Oct 12, 2017 at 10:40:42PM +0100, Christos Gkekas wrote:
> Remove variables 'start' and 'end', which are set but never used.
Oops.
Reviewed-by: Omar Sandoval <osandov@fb.com>
> Signed-off-by: Christos Gkekas <chris.gekas@gmail.com>
> ---
> fs/btrfs/free-space-tree.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/fs/btrfs/free-space-tree.c b/fs/btrfs/free-space-tree.c
> index 684f122..fe5e032 100644
> --- a/fs/btrfs/free-space-tree.c
> +++ b/fs/btrfs/free-space-tree.c
> @@ -1286,12 +1286,8 @@ static int __add_block_group_free_space(struct btrfs_trans_handle *trans,
> struct btrfs_block_group_cache *block_group,
> struct btrfs_path *path)
> {
> - u64 start, end;
> int ret;
>
> - start = block_group->key.objectid;
> - end = block_group->key.objectid + block_group->key.offset;
> -
> block_group->needs_free_space = 0;
>
> ret = add_new_free_space_info(trans, fs_info, block_group, path);
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] btrfs: Clean up unused variables in free-space-tree.c
2017-10-12 21:43 ` Omar Sandoval
@ 2017-10-13 12:08 ` David Sterba
0 siblings, 0 replies; 3+ messages in thread
From: David Sterba @ 2017-10-13 12:08 UTC (permalink / raw)
To: Omar Sandoval
Cc: Christos Gkekas, Chris Mason, Josef Bacik, David Sterba,
linux-btrfs, linux-kernel
On Thu, Oct 12, 2017 at 02:43:27PM -0700, Omar Sandoval wrote:
> On Thu, Oct 12, 2017 at 10:40:42PM +0100, Christos Gkekas wrote:
> > Remove variables 'start' and 'end', which are set but never used.
>
> Oops.
>
> Reviewed-by: Omar Sandoval <osandov@fb.com>
Thanks, added to the queue.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-10-13 12:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-12 21:40 [PATCH] btrfs: Clean up unused variables in free-space-tree.c Christos Gkekas
2017-10-12 21:43 ` Omar Sandoval
2017-10-13 12:08 ` David Sterba
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).