From: Nikolay Borisov <nborisov@suse.com>
To: linux-btrfs@vger.kernel.org
Cc: Nikolay Borisov <nborisov@suse.com>
Subject: [PATCH 2/5] btrfs: Remove dead code
Date: Fri, 1 Dec 2017 11:19:41 +0200 [thread overview]
Message-ID: <1512119984-12708-3-git-send-email-nborisov@suse.com> (raw)
In-Reply-To: <1512119984-12708-1-git-send-email-nborisov@suse.com>
'clear' is always set to 0 (BTRFS_FEATURE_COMPAT_SAFE_CLEAR,
BTRFS_FEATURE_COMPAT_RO_SAFE_CLEAR and BTRFS_FEATURE_INCOMPAT_SAFE_CLEAR are
all defined to 0). So remove the code that logically can never execute.
Signed-off-by: Nikolay Borisov <nborisov@suse.com>
---
fs/btrfs/sysfs.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs/btrfs/sysfs.c b/fs/btrfs/sysfs.c
index a8bafed931f4..37dbf2fccedc 100644
--- a/fs/btrfs/sysfs.c
+++ b/fs/btrfs/sysfs.c
@@ -84,8 +84,6 @@ static int can_modify_feature(struct btrfs_feature_attr *fa)
if (set & fa->feature_bit)
val |= 1;
- if (clear & fa->feature_bit)
- val |= 2;
return val;
}
--
2.7.4
next prev parent reply other threads:[~2017-12-01 9:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-01 9:19 [PATCH 0/5] Misc cleanups Nikolay Borisov
2017-12-01 9:19 ` [PATCH 1/5] btrfs: Remove dead code Nikolay Borisov
2017-12-04 13:45 ` David Sterba
2017-12-05 11:53 ` [PATCH] btrfs: Remove dead code btrfs_get_extent Nikolay Borisov
2017-12-01 9:19 ` Nikolay Borisov [this message]
2017-12-04 13:50 ` [PATCH 2/5] btrfs: Remove dead code David Sterba
2017-12-04 16:17 ` Nikolay Borisov
2017-12-01 9:19 ` [PATCH 3/5] btrfs: Fix possible off-by-one in btrfs_search_path_in_tree Nikolay Borisov
2017-12-06 15:48 ` David Sterba
2017-12-01 9:19 ` [PATCH 4/5] btrfs: Remove redundant NULL check Nikolay Borisov
2017-12-06 16:02 ` David Sterba
2017-12-01 9:19 ` [PATCH 5/5] btrfs: Greatly simplify btrfs_read_dev_super Nikolay Borisov
2017-12-01 23:23 ` Anand Jain
2017-12-03 9:43 ` Nikolay Borisov
2017-12-04 1:33 ` Anand Jain
2017-12-04 14:13 ` David Sterba
2017-12-04 16:20 ` Nikolay Borisov
2017-12-06 16:24 ` David Sterba
[not found] ` <24281483-900c-ab1b-c407-5fa6983f5311@oracle.com>
2017-12-08 8:13 ` Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1512119984-12708-3-git-send-email-nborisov@suse.com \
--to=nborisov@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).