From: Nikolay Borisov <nborisov@suse.com>
To: linux-btrfs@vger.kernel.org
Cc: Nikolay Borisov <nborisov@suse.com>
Subject: [PATCH RESEND 4/4] btrfs: Remove btrfs_fs_info::open_ioctl_trans
Date: Wed, 10 Jan 2018 18:32:13 +0200 [thread overview]
Message-ID: <1515601933-27331-4-git-send-email-nborisov@suse.com> (raw)
In-Reply-To: <1515601933-27331-1-git-send-email-nborisov@suse.com>
Since userspace transaction have been removed we no longer have use
for this field so delete it.
Signed-off-by: Nikolay Borisov <nborisov@suse.com>
---
fs/btrfs/ctree.h | 1 -
fs/btrfs/extent-tree.c | 3 +--
fs/btrfs/transaction.c | 9 +++------
3 files changed, 4 insertions(+), 9 deletions(-)
diff --git a/fs/btrfs/ctree.h b/fs/btrfs/ctree.h
index dc679246b8e8..57a0d0b0ea74 100644
--- a/fs/btrfs/ctree.h
+++ b/fs/btrfs/ctree.h
@@ -877,7 +877,6 @@ struct btrfs_fs_info {
struct rb_root tree_mod_log;
atomic_t async_delalloc_pages;
- atomic_t open_ioctl_trans;
/*
* this is used to protect the following list -- ordered_roots.
diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c
index 8d51e4bb67c1..dcb059a46b77 100644
--- a/fs/btrfs/extent-tree.c
+++ b/fs/btrfs/extent-tree.c
@@ -4329,8 +4329,7 @@ int btrfs_alloc_data_chunk_ondemand(struct btrfs_inode *inode, u64 bytes)
/* commit the current transaction and try again */
commit_trans:
- if (need_commit &&
- !atomic_read(&fs_info->open_ioctl_trans)) {
+ if (need_commit) {
need_commit--;
if (need_commit > 0) {
diff --git a/fs/btrfs/transaction.c b/fs/btrfs/transaction.c
index d61d1fd59ccd..c5ef42318058 100644
--- a/fs/btrfs/transaction.c
+++ b/fs/btrfs/transaction.c
@@ -443,8 +443,7 @@ static int may_wait_transaction(struct btrfs_fs_info *fs_info, int type)
if (test_bit(BTRFS_FS_LOG_RECOVERING, &fs_info->flags))
return 0;
- if (type == TRANS_START &&
- !atomic_read(&fs_info->open_ioctl_trans))
+ if (type == TRANS_START)
return 1;
return 0;
@@ -774,8 +773,7 @@ int btrfs_wait_for_commit(struct btrfs_fs_info *fs_info, u64 transid)
void btrfs_throttle(struct btrfs_fs_info *fs_info)
{
- if (!atomic_read(&fs_info->open_ioctl_trans))
- wait_current_trans(fs_info);
+ wait_current_trans(fs_info);
}
static int should_end_transaction(struct btrfs_trans_handle *trans)
@@ -857,8 +855,7 @@ static int __btrfs_end_transaction(struct btrfs_trans_handle *trans,
btrfs_trans_release_chunk_metadata(trans);
- if (lock && !atomic_read(&info->open_ioctl_trans) &&
- should_end_transaction(trans) &&
+ if (lock && should_end_transaction(trans) &&
READ_ONCE(cur_trans->state) == TRANS_STATE_RUNNING) {
spin_lock(&info->trans_lock);
if (cur_trans->state == TRANS_STATE_RUNNING)
--
2.7.4
next prev parent reply other threads:[~2018-01-10 16:32 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-10 13:21 [PATCH 0/4] Finally remove userspace transaction support Nikolay Borisov
2018-01-10 13:21 ` [PATCH 1/4] btrfs: Remove userspace transaction ioctls Nikolay Borisov
2018-01-10 13:37 ` [PATCH v2] " Nikolay Borisov
2018-01-10 13:40 ` [PATCH v3] " Nikolay Borisov
2018-01-10 13:21 ` [PATCH 2/4] btrfs: Remove code referencing unused TRANS_USERSPACE Nikolay Borisov
2018-01-10 13:21 ` [PATCH 3/4] btrfs: Remove transaction handle from btrfs_file_private Nikolay Borisov
2018-01-10 13:21 ` [PATCH 4/4] btrfs: Remove btrfs_fs_info::open_ioctl_trans Nikolay Borisov
2018-01-10 15:47 ` [PATCH 0/4] Finally remove userspace transaction support Josef Bacik
2018-01-10 16:26 ` David Sterba
2018-01-10 16:32 ` [PATCH RESEND 1/4] btrfs: Remove userspace transaction ioctls Nikolay Borisov
2018-01-10 16:32 ` [PATCH RESEND 2/4] btrfs: Remove code referencing unused TRANS_USERSPACE Nikolay Borisov
2018-02-02 17:40 ` David Sterba
2018-01-10 16:32 ` [PATCH RESEND 3/4] btrfs: Remove transaction handle from btrfs_file_private Nikolay Borisov
2018-02-02 17:40 ` David Sterba
2018-01-10 16:32 ` Nikolay Borisov [this message]
2018-02-02 17:40 ` [PATCH RESEND 4/4] btrfs: Remove btrfs_fs_info::open_ioctl_trans David Sterba
2018-02-02 17:39 ` [PATCH RESEND 1/4] btrfs: Remove userspace transaction ioctls David Sterba
2018-02-02 17:45 ` David Sterba
2018-02-05 8:41 ` [PATCH v2 " Nikolay Borisov
2018-02-05 8:41 ` [PATCH v2 2/4] btrfs: Remove btrfs_file_private::trans Nikolay Borisov
2018-02-05 8:41 ` [PATCH v2 3/4] btrfs: Remove code referencing unused TRANS_USERSPACE Nikolay Borisov
2018-02-05 8:41 ` [PATCH v2 4/4] btrfs: Remove btrfs_fs_info::open_ioctl_trans Nikolay Borisov
2018-02-05 8:52 ` [PATCH v2 1/4] btrfs: Remove userspace transaction ioctls Wang Shilong
2018-02-05 13:30 ` David Sterba
2018-02-05 14:27 ` Sage Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1515601933-27331-4-git-send-email-nborisov@suse.com \
--to=nborisov@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).