* [PATCH] btrfs: Remove stale comment about select_delayed_ref
@ 2018-05-17 11:16 Nikolay Borisov
2018-05-17 17:09 ` David Sterba
0 siblings, 1 reply; 2+ messages in thread
From: Nikolay Borisov @ 2018-05-17 11:16 UTC (permalink / raw)
To: linux-btrfs; +Cc: Nikolay Borisov
select_delayed_ref really just gets the next delayed ref which has to
be processed - either an add ref or drop ref. We never go back for
anything. So the comment is actually bogus, just remove it.
Signed-off-by: Nikolay Borisov <nborisov@suse.com>
---
fs/btrfs/extent-tree.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c
index 795dc533856f..cae33c531a3c 100644
--- a/fs/btrfs/extent-tree.c
+++ b/fs/btrfs/extent-tree.c
@@ -2705,10 +2705,6 @@ static noinline int __btrfs_run_delayed_refs(struct btrfs_trans_handle *trans,
spin_lock(&locked_ref->lock);
btrfs_merge_delayed_refs(trans, delayed_refs, locked_ref);
- /*
- * locked_ref is the head node, so we have to go one
- * node back for any delayed ref updates
- */
ref = select_delayed_ref(locked_ref);
if (ref && ref->seq &&
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] btrfs: Remove stale comment about select_delayed_ref
2018-05-17 11:16 [PATCH] btrfs: Remove stale comment about select_delayed_ref Nikolay Borisov
@ 2018-05-17 17:09 ` David Sterba
0 siblings, 0 replies; 2+ messages in thread
From: David Sterba @ 2018-05-17 17:09 UTC (permalink / raw)
To: Nikolay Borisov; +Cc: linux-btrfs
On Thu, May 17, 2018 at 02:16:29PM +0300, Nikolay Borisov wrote:
> select_delayed_ref really just gets the next delayed ref which has to
> be processed - either an add ref or drop ref. We never go back for
> anything. So the comment is actually bogus, just remove it.
>
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
Added to misc-next, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-05-17 17:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-17 11:16 [PATCH] btrfs: Remove stale comment about select_delayed_ref Nikolay Borisov
2018-05-17 17:09 ` David Sterba
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).