* [PATCH] Btrfs: remove confusing tracepoint in btrfs_add_reserved_bytes
@ 2018-09-05 1:37 Liu Bo
2018-09-05 1:55 ` [PATCH v2] " Liu Bo
0 siblings, 1 reply; 4+ messages in thread
From: Liu Bo @ 2018-09-05 1:37 UTC (permalink / raw)
To: linux-btrfs
Signed-off-by: Liu Bo <bo.liu@linux.alibaba.com>
---
fs/btrfs/extent-tree.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c
index 41a02cbb5a4a..76ee5ebef2b9 100644
--- a/fs/btrfs/extent-tree.c
+++ b/fs/btrfs/extent-tree.c
@@ -6401,10 +6401,6 @@ static int btrfs_add_reserved_bytes(struct btrfs_block_group_cache *cache,
} else {
cache->reserved += num_bytes;
space_info->bytes_reserved += num_bytes;
-
- trace_btrfs_space_reservation(cache->fs_info,
- "space_info", space_info->flags,
- ram_bytes, 0);
space_info->bytes_may_use -= ram_bytes;
if (delalloc)
cache->delalloc_bytes += num_bytes;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH v2] Btrfs: remove confusing tracepoint in btrfs_add_reserved_bytes
2018-09-05 1:37 [PATCH] Btrfs: remove confusing tracepoint in btrfs_add_reserved_bytes Liu Bo
@ 2018-09-05 1:55 ` Liu Bo
2018-09-05 6:00 ` Nikolay Borisov
2018-09-06 15:39 ` David Sterba
0 siblings, 2 replies; 4+ messages in thread
From: Liu Bo @ 2018-09-05 1:55 UTC (permalink / raw)
To: linux-btrfs
Here we're not releasing any space, but transferring bytes from
->bytes_may_use to ->bytes_reserved.
Signed-off-by: Liu Bo <bo.liu@linux.alibaba.com>
---
v2: Add missing commit log.
fs/btrfs/extent-tree.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c
index 41a02cbb5a4a..76ee5ebef2b9 100644
--- a/fs/btrfs/extent-tree.c
+++ b/fs/btrfs/extent-tree.c
@@ -6401,10 +6401,6 @@ static int btrfs_add_reserved_bytes(struct btrfs_block_group_cache *cache,
} else {
cache->reserved += num_bytes;
space_info->bytes_reserved += num_bytes;
-
- trace_btrfs_space_reservation(cache->fs_info,
- "space_info", space_info->flags,
- ram_bytes, 0);
space_info->bytes_may_use -= ram_bytes;
if (delalloc)
cache->delalloc_bytes += num_bytes;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2] Btrfs: remove confusing tracepoint in btrfs_add_reserved_bytes
2018-09-05 1:55 ` [PATCH v2] " Liu Bo
@ 2018-09-05 6:00 ` Nikolay Borisov
2018-09-06 15:39 ` David Sterba
1 sibling, 0 replies; 4+ messages in thread
From: Nikolay Borisov @ 2018-09-05 6:00 UTC (permalink / raw)
To: Liu Bo, linux-btrfs
On 5.09.2018 04:55, Liu Bo wrote:
> Here we're not releasing any space, but transferring bytes from
> ->bytes_may_use to ->bytes_reserved.
>
> Signed-off-by: Liu Bo <bo.liu@linux.alibaba.com>
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
> ---
> v2: Add missing commit log.
>
> fs/btrfs/extent-tree.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c
> index 41a02cbb5a4a..76ee5ebef2b9 100644
> --- a/fs/btrfs/extent-tree.c
> +++ b/fs/btrfs/extent-tree.c
> @@ -6401,10 +6401,6 @@ static int btrfs_add_reserved_bytes(struct btrfs_block_group_cache *cache,
> } else {
> cache->reserved += num_bytes;
> space_info->bytes_reserved += num_bytes;
> -
> - trace_btrfs_space_reservation(cache->fs_info,
> - "space_info", space_info->flags,
> - ram_bytes, 0);
> space_info->bytes_may_use -= ram_bytes;
> if (delalloc)
> cache->delalloc_bytes += num_bytes;
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] Btrfs: remove confusing tracepoint in btrfs_add_reserved_bytes
2018-09-05 1:55 ` [PATCH v2] " Liu Bo
2018-09-05 6:00 ` Nikolay Borisov
@ 2018-09-06 15:39 ` David Sterba
1 sibling, 0 replies; 4+ messages in thread
From: David Sterba @ 2018-09-06 15:39 UTC (permalink / raw)
To: Liu Bo; +Cc: linux-btrfs
On Wed, Sep 05, 2018 at 09:55:27AM +0800, Liu Bo wrote:
> Here we're not releasing any space, but transferring bytes from
> ->bytes_may_use to ->bytes_reserved.
>
> Signed-off-by: Liu Bo <bo.liu@linux.alibaba.com>
> ---
> v2: Add missing commit log.
I've enhanced the changlog a bit how the tracepoint got there.
Reviewed-by: David Sterba <dsterba@suse.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-09-06 20:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-05 1:37 [PATCH] Btrfs: remove confusing tracepoint in btrfs_add_reserved_bytes Liu Bo
2018-09-05 1:55 ` [PATCH v2] " Liu Bo
2018-09-05 6:00 ` Nikolay Borisov
2018-09-06 15:39 ` David Sterba
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).