* [PATCH] btrfs: list usage cleanup
@ 2018-09-26 8:35 zhong jiang
2018-09-26 8:53 ` Nikolay Borisov
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: zhong jiang @ 2018-09-26 8:35 UTC (permalink / raw)
To: dsterba; +Cc: jbacik, clm, linux-btrfs, linux-kernel
Trival cleanup, list_move_tail will implement the same function that
list_del() + list_add_tail() will do. hence just replace them.
Signed-off-by: zhong jiang <zhongjiang@huawei.com>
---
fs/btrfs/send.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c
index 094cc144..d87f416 100644
--- a/fs/btrfs/send.c
+++ b/fs/btrfs/send.c
@@ -2075,8 +2075,7 @@ static struct name_cache_entry *name_cache_search(struct send_ctx *sctx,
*/
static void name_cache_used(struct send_ctx *sctx, struct name_cache_entry *nce)
{
- list_del(&nce->list);
- list_add_tail(&nce->list, &sctx->name_cache_list);
+ list_move_tail(&nce->list, &sctx->name_cache_list);
}
/*
--
1.7.12.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] btrfs: list usage cleanup 2018-09-26 8:35 [PATCH] btrfs: list usage cleanup zhong jiang @ 2018-09-26 8:53 ` Nikolay Borisov 2018-09-27 9:07 ` David Sterba 2018-09-27 18:47 ` Omar Sandoval 2 siblings, 0 replies; 6+ messages in thread From: Nikolay Borisov @ 2018-09-26 8:53 UTC (permalink / raw) To: zhong jiang, dsterba; +Cc: jbacik, clm, linux-btrfs, linux-kernel On 26.09.2018 11:35, zhong jiang wrote: > Trival cleanup, list_move_tail will implement the same function that > list_del() + list_add_tail() will do. hence just replace them. > > Signed-off-by: zhong jiang <zhongjiang@huawei.com> Reviewed-by: Nikolay Borisov <nborisov@suse.com> > --- > fs/btrfs/send.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c > index 094cc144..d87f416 100644 > --- a/fs/btrfs/send.c > +++ b/fs/btrfs/send.c > @@ -2075,8 +2075,7 @@ static struct name_cache_entry *name_cache_search(struct send_ctx *sctx, > */ > static void name_cache_used(struct send_ctx *sctx, struct name_cache_entry *nce) > { > - list_del(&nce->list); > - list_add_tail(&nce->list, &sctx->name_cache_list); > + list_move_tail(&nce->list, &sctx->name_cache_list); > } > > /* > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] btrfs: list usage cleanup 2018-09-26 8:35 [PATCH] btrfs: list usage cleanup zhong jiang 2018-09-26 8:53 ` Nikolay Borisov @ 2018-09-27 9:07 ` David Sterba 2018-09-27 18:47 ` Omar Sandoval 2 siblings, 0 replies; 6+ messages in thread From: David Sterba @ 2018-09-27 9:07 UTC (permalink / raw) To: zhong jiang; +Cc: dsterba, jbacik, clm, linux-btrfs, linux-kernel On Wed, Sep 26, 2018 at 04:35:45PM +0800, zhong jiang wrote: > Trival cleanup, list_move_tail will implement the same function that > list_del() + list_add_tail() will do. hence just replace them. Thanks, I've checked that this is the only instance where this cleanup is applicable. Reviewed-by: David Sterba <dsterba@suse.com> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] btrfs: list usage cleanup 2018-09-26 8:35 [PATCH] btrfs: list usage cleanup zhong jiang 2018-09-26 8:53 ` Nikolay Borisov 2018-09-27 9:07 ` David Sterba @ 2018-09-27 18:47 ` Omar Sandoval 2018-10-01 16:48 ` David Sterba 2 siblings, 1 reply; 6+ messages in thread From: Omar Sandoval @ 2018-09-27 18:47 UTC (permalink / raw) To: zhong jiang; +Cc: dsterba, jbacik, clm, linux-btrfs, linux-kernel On Wed, Sep 26, 2018 at 04:35:45PM +0800, zhong jiang wrote: > Trival cleanup, list_move_tail will implement the same function that > list_del() + list_add_tail() will do. hence just replace them. > > Signed-off-by: zhong jiang <zhongjiang@huawei.com> > --- > fs/btrfs/send.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c > index 094cc144..d87f416 100644 > --- a/fs/btrfs/send.c > +++ b/fs/btrfs/send.c > @@ -2075,8 +2075,7 @@ static struct name_cache_entry *name_cache_search(struct send_ctx *sctx, > */ > static void name_cache_used(struct send_ctx *sctx, struct name_cache_entry *nce) > { > - list_del(&nce->list); > - list_add_tail(&nce->list, &sctx->name_cache_list); > + list_move_tail(&nce->list, &sctx->name_cache_list); > } At that point do we even need such a trivial helper, considering that this is only called in one place? ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] btrfs: list usage cleanup 2018-09-27 18:47 ` Omar Sandoval @ 2018-10-01 16:48 ` David Sterba 2018-10-04 3:25 ` zhong jiang 0 siblings, 1 reply; 6+ messages in thread From: David Sterba @ 2018-10-01 16:48 UTC (permalink / raw) To: Omar Sandoval Cc: zhong jiang, dsterba, jbacik, clm, linux-btrfs, linux-kernel On Thu, Sep 27, 2018 at 11:47:04AM -0700, Omar Sandoval wrote: > On Wed, Sep 26, 2018 at 04:35:45PM +0800, zhong jiang wrote: > > Trival cleanup, list_move_tail will implement the same function that > > list_del() + list_add_tail() will do. hence just replace them. > > > > Signed-off-by: zhong jiang <zhongjiang@huawei.com> > > --- > > fs/btrfs/send.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c > > index 094cc144..d87f416 100644 > > --- a/fs/btrfs/send.c > > +++ b/fs/btrfs/send.c > > @@ -2075,8 +2075,7 @@ static struct name_cache_entry *name_cache_search(struct send_ctx *sctx, > > */ > > static void name_cache_used(struct send_ctx *sctx, struct name_cache_entry *nce) > > { > > - list_del(&nce->list); > > - list_add_tail(&nce->list, &sctx->name_cache_list); > > + list_move_tail(&nce->list, &sctx->name_cache_list); > > } > > At that point do we even need such a trivial helper, considering that > this is only called in one place? Fair point and trivial one-line helpers are on the cleanup todo list. The exception is when the actual helper implementation is obscuring the semantics and the helper is used in many places so it's not practical to add a comment everywhere. But it's not the case here. Zhong Jiang, please update the patch and resend, thanks. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] btrfs: list usage cleanup 2018-10-01 16:48 ` David Sterba @ 2018-10-04 3:25 ` zhong jiang 0 siblings, 0 replies; 6+ messages in thread From: zhong jiang @ 2018-10-04 3:25 UTC (permalink / raw) To: dsterba, Omar Sandoval, dsterba, jbacik, clm, linux-btrfs, linux-kernel On 2018/10/2 0:48, David Sterba wrote: > On Thu, Sep 27, 2018 at 11:47:04AM -0700, Omar Sandoval wrote: >> On Wed, Sep 26, 2018 at 04:35:45PM +0800, zhong jiang wrote: >>> Trival cleanup, list_move_tail will implement the same function that >>> list_del() + list_add_tail() will do. hence just replace them. >>> >>> Signed-off-by: zhong jiang <zhongjiang@huawei.com> >>> --- >>> fs/btrfs/send.c | 3 +-- >>> 1 file changed, 1 insertion(+), 2 deletions(-) >>> >>> diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c >>> index 094cc144..d87f416 100644 >>> --- a/fs/btrfs/send.c >>> +++ b/fs/btrfs/send.c >>> @@ -2075,8 +2075,7 @@ static struct name_cache_entry *name_cache_search(struct send_ctx *sctx, >>> */ >>> static void name_cache_used(struct send_ctx *sctx, struct name_cache_entry *nce) >>> { >>> - list_del(&nce->list); >>> - list_add_tail(&nce->list, &sctx->name_cache_list); >>> + list_move_tail(&nce->list, &sctx->name_cache_list); >>> } >> At that point do we even need such a trivial helper, considering that >> this is only called in one place? > Fair point and trivial one-line helpers are on the cleanup todo list. > The exception is when the actual helper implementation is obscuring the > semantics and the helper is used in many places so it's not practical to > add a comment everywhere. But it's not the case here. > > Zhong Jiang, please update the patch and resend, thanks. Will add a comment here and resend in v2. Thanks, zhong jiang > . > ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-10-04 3:26 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-09-26 8:35 [PATCH] btrfs: list usage cleanup zhong jiang 2018-09-26 8:53 ` Nikolay Borisov 2018-09-27 9:07 ` David Sterba 2018-09-27 18:47 ` Omar Sandoval 2018-10-01 16:48 ` David Sterba 2018-10-04 3:25 ` zhong jiang
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).