From: Anand Jain <anand.jain@oracle.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH 2/3] btrfs: sysfs, add readmirror kobject
Date: Fri, 20 Dec 2019 13:06:04 +0800 [thread overview]
Message-ID: <1576818365-20286-3-git-send-email-anand.jain@oracle.com> (raw)
In-Reply-To: <1576818365-20286-1-git-send-email-anand.jain@oracle.com>
Add
/sys/fs/btrfs/UUID/readmirror
kobject so that we can be the readmirror policies as attributes under it.
Signed-off-by: Anand Jain <anand.jain@oracle.com>
---
fs/btrfs/sysfs.c | 22 ++++++++++++++++++++++
fs/btrfs/volumes.h | 1 +
2 files changed, 23 insertions(+)
diff --git a/fs/btrfs/sysfs.c b/fs/btrfs/sysfs.c
index d414b98fb27f..da5e1938e9b9 100644
--- a/fs/btrfs/sysfs.c
+++ b/fs/btrfs/sysfs.c
@@ -355,6 +355,10 @@ static ssize_t supported_checksums_show(struct kobject *kobj,
#endif
+static const struct attribute *btrfs_readmirror_attrs[] = {
+ NULL,
+};
+
static ssize_t btrfs_show_u64(u64 *value_ptr, spinlock_t *lock, char *buf)
{
u64 val;
@@ -772,6 +776,13 @@ void btrfs_sysfs_remove_mounted(struct btrfs_fs_info *fs_info)
{
btrfs_reset_fs_info_ptr(fs_info);
+ if (fs_info->fs_devices->readmirror_kobj) {
+ sysfs_remove_files(fs_info->fs_devices->readmirror_kobj,
+ btrfs_readmirror_attrs);
+ kobject_del(fs_info->fs_devices->readmirror_kobj);
+ kobject_put(fs_info->fs_devices->readmirror_kobj);
+ }
+
if (fs_info->space_info_kobj) {
sysfs_remove_files(fs_info->space_info_kobj, allocation_attrs);
kobject_del(fs_info->space_info_kobj);
@@ -1224,6 +1235,17 @@ int btrfs_sysfs_add_mounted(struct btrfs_fs_info *fs_info)
if (error)
goto failure;
+ fs_devs->readmirror_kobj = kobject_create_and_add("readmirror",
+ &fs_devs->fsid_kobj);
+ if (!fs_devs->readmirror_kobj) {
+ error = -ENOMEM;
+ goto failure;
+ }
+ error = sysfs_create_files(fs_info->readmirror_kobj,
+ btrfs_readmirror_attrs);
+ if (error)
+ goto failure;
+
return 0;
failure:
btrfs_sysfs_remove_mounted(fs_info);
diff --git a/fs/btrfs/volumes.h b/fs/btrfs/volumes.h
index d9c4c4e1dbc2..5a9fca16a8a6 100644
--- a/fs/btrfs/volumes.h
+++ b/fs/btrfs/volumes.h
@@ -268,6 +268,7 @@ struct btrfs_fs_devices {
struct completion kobj_unregister;
atomic_t readmirror;
+ struct kobject *readmirror_kobj;
};
#define BTRFS_BIO_INLINE_CSUM_SIZE 64
--
1.8.3.1
next prev parent reply other threads:[~2019-12-20 5:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-20 5:06 [PATCH 0/3] readmirror feature (sysfs and in-memory only approach) Anand Jain
2019-12-20 5:06 ` [PATCH 1/3] btrfs: add readmirror type framework Anand Jain
2019-12-20 14:44 ` Josef Bacik
2020-01-02 10:12 ` Anand Jain
2019-12-20 5:06 ` Anand Jain [this message]
2019-12-20 5:06 ` [PATCH 3/3] btrfs: sysfs, create by_pid readmirror attribute Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1576818365-20286-3-git-send-email-anand.jain@oracle.com \
--to=anand.jain@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox