public inbox for linux-btrfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Long An <lan@suse.com>
To: "linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] btrfs-progs: fix path for btrfs-corrupt-block
Date: Fri, 10 Jan 2020 09:34:49 +0000	[thread overview]
Message-ID: <1578648888.3609.5.camel@suse.com> (raw)
In-Reply-To: <MN2PR18MB2685D76F7AFF7508E8101982C6380@MN2PR18MB2685.namprd18.prod.outlook.com>

As wenruo said, file generation function might be better.
But I think that even so, it still needs to be fixed.

On Fri, 2020-01-10 at 09:26 +0000, Long An wrote:
> btrfs-corrupt-block path is wrong on exported testsutie. Fix this
> issue
> for below tests:
> fsck-tests/037-freespacetree-repair
> misc-tests/038-backup-root-corruption
> 
> Signed-off-by: An Long <lan@suse.com>
> ---
>  tests/fsck-tests/037-freespacetree-repair/test.sh   | 2 +-
>  tests/misc-tests/038-backup-root-corruption/test.sh | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/fsck-tests/037-freespacetree-repair/test.sh
> b/tests/fsck-tests/037-freespacetree-repair/test.sh
> index d7ee0f21..49165fcd 100755
> --- a/tests/fsck-tests/037-freespacetree-repair/test.sh
> +++ b/tests/fsck-tests/037-freespacetree-repair/test.sh
> @@ -46,7 +46,7 @@ corrupt_fst_item()
>                 _fail "Unknown item type for corruption"
>         fi
> 
> -       run_check "$TOP/btrfs-corrupt-block" -r 10 -K
> "$objectid,$type,$offset" \
> +       run_check "$INTERNAL_BIN/btrfs-corrupt-block" -r 10 -K
> "$objectid,$type,$offset" \
>                 -f offset "$TEST_DEV"
>  }
> 
> diff --git a/tests/misc-tests/038-backup-root-corruption/test.sh
> b/tests/misc-tests/038-backup-root-corruption/test.sh
> index f15d0bba..a970691b 100755
> --- a/tests/misc-tests/038-backup-root-corruption/test.sh
> +++ b/tests/misc-tests/038-backup-root-corruption/test.sh
> @@ -27,7 +27,7 @@ main_root_ptr=$(dump_super | grep root | head -n1 |
> awk '{print $2}')
> 
>  [ "$backup2_root_ptr" -eq "$main_root_ptr" ] || _fail "Backup slot 2
> is not in use"
> 
> -run_check "$TOP/btrfs-corrupt-block" -m $main_root_ptr -f generation
> "$TEST_DEV"
> +run_check "$INTERNAL_BIN/btrfs-corrupt-block" -m $main_root_ptr -f
> generation "$TEST_DEV"
> 
>  # Should fail because the root is corrupted
>  run_mustfail "Unexpected successful mount" \
> --
> 2.16.4
> 
> 
-- 
An Long <lan@suse.com>
SUSE SLE-QA , APAC-2 Beijing

       reply	other threads:[~2020-01-10  9:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20191219025220.31764-1-lan@suse.com>
     [not found] ` <MN2PR18MB2685D76F7AFF7508E8101982C6380@MN2PR18MB2685.namprd18.prod.outlook.com>
2020-01-10  9:34   ` Long An [this message]
2020-01-10  9:49 [PATCH] btrfs-progs: fix path for btrfs-corrupt-block Long An
2020-01-13 21:52 ` David Sterba
  -- strict thread matches above, loose matches on Subject: below --
2019-12-18 10:30 Long An
2019-12-18 11:26 ` Qu Wenruo
2019-12-19  2:28   ` Long An

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1578648888.3609.5.camel@suse.com \
    --to=lan@suse.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox