From: Diego <diegocg@gmail.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH] Improve error stats message
Date: Wed, 07 Mar 2018 18:37:29 +0100 [thread overview]
Message-ID: <1588327.cr4xlG2VNd@archlinux> (raw)
A typical notification of filesystem errors looks like this:
BTRFS error (device sda2): bdev /dev/sda2 errs: wr 0, rd 1, flush 0, corrupt 0, gen 0
The device name is being printed twice. Also, these abbreviatures
feel unnecesary. Make the message look like this instead:
BTRFS error (device sda2): errors: write 0, read 1, flush 0, corrupt 0, generation 0
Signed-off-by: Diego Calleja <diegocg@gmail.com>
---
fs/btrfs/volumes.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index 2ceb924ca0d6..52fee5bb056f 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -7238,9 +7238,8 @@ static void btrfs_dev_stat_print_on_error(struct btrfs_device *dev)
{
if (!dev->dev_stats_valid)
return;
- btrfs_err_rl_in_rcu(dev->fs_info,
- "bdev %s errs: wr %u, rd %u, flush %u, corrupt %u, gen %u",
- rcu_str_deref(dev->name),
+ btrfs_err_rl(dev->fs_info,
+ "errors: write %u, read %u, flush %u, corrupt %u, generation %u",
btrfs_dev_stat_read(dev, BTRFS_DEV_STAT_WRITE_ERRS),
btrfs_dev_stat_read(dev, BTRFS_DEV_STAT_READ_ERRS),
btrfs_dev_stat_read(dev, BTRFS_DEV_STAT_FLUSH_ERRS),
--
2.16.2
next reply other threads:[~2018-03-07 17:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-07 17:37 Diego [this message]
2018-03-07 18:24 ` [PATCH] Improve error stats message Hugo Mills
2018-03-07 19:02 ` Diego
2018-03-07 20:35 ` Hugo Mills
2018-03-08 7:28 ` Nikolay Borisov
2018-03-08 10:04 ` Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1588327.cr4xlG2VNd@archlinux \
--to=diegocg@gmail.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).