public inbox for linux-btrfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Qu Wenruo <wqu@suse.com>
To: Johannes Thumshirn <johannes.thumshirn@wdc.com>,
	linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: pass 'verbose' parameter to btrfs_relocate_block_group
Date: Mon, 2 Mar 2026 20:44:30 +1030	[thread overview]
Message-ID: <15f543c6-acec-48f5-bfd5-e14e15c5d8ab@suse.com> (raw)
In-Reply-To: <20260227131224.159801-1-johannes.thumshirn@wdc.com>



在 2026/2/27 23:42, Johannes Thumshirn 写道:
> Function `btrfs_relocate_chunk()` always passes verbose=true to
> `btrfs_relocate_block_group()` instead of the `verbose` parameter passed
> into it by it's callers.
> 
> While user initiated rebalancing should be logged in the Kernel's log
> buffer. This causes excessive log spamming from automatic rebalancing,
> e.g. on zoned filesystems running low on usable space.
> 
> Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>

Reviewed-by: Qu Wenruo <wqu@suse.com>

Thanks,
Qu

> ---
>   fs/btrfs/volumes.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
> index c0cf8f7c5a8e..95accc9361bd 100644
> --- a/fs/btrfs/volumes.c
> +++ b/fs/btrfs/volumes.c
> @@ -3595,7 +3595,7 @@ int btrfs_relocate_chunk(struct btrfs_fs_info *fs_info, u64 chunk_offset, bool v
>   
>   	/* step one, relocate all the extents inside this chunk */
>   	btrfs_scrub_pause(fs_info);
> -	ret = btrfs_relocate_block_group(fs_info, chunk_offset, true);
> +	ret = btrfs_relocate_block_group(fs_info, chunk_offset, verbose);
>   	btrfs_scrub_continue(fs_info);
>   	if (ret) {
>   		/*


  parent reply	other threads:[~2026-03-02 10:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-27 13:12 [PATCH] btrfs: pass 'verbose' parameter to btrfs_relocate_block_group Johannes Thumshirn
2026-02-27 13:31 ` Damien Le Moal
2026-03-02 10:14 ` Qu Wenruo [this message]
2026-03-02 10:21 ` Filipe Manana

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15f543c6-acec-48f5-bfd5-e14e15c5d8ab@suse.com \
    --to=wqu@suse.com \
    --cc=johannes.thumshirn@wdc.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox