Re: 6.1.140 build failure(fs/btrfs/discard.c:247:5: error: implicit declaration of function 'ASSERT')

[Qu Wenruo <quwenruo.btrfs@gmx.com>]

在 2025/5/26 15:10, Wang Yugui 写道:
> Hi,
> Cc: Filipe Manana
> 
> I noticed 6.1.140 build failure(fs/btrfs/discard.c:247:5: error: implicit declaration of function 'ASSERT')
> 
> fs/btrfs/discard.c: In function 'peek_discard_list':
> fs/btrfs/discard.c:247:5: error: implicit declaration of function 'ASSERT'; did you mean 'IS_ERR'? [-Werror=implicit-function-declaration]
>       ASSERT(block_group->discard_index !=
>       ^~~~~~
>       IS_ERR
> 
> It seems realted to the patch(btrfs-fix-discard-worker-infinite-loop-after-disabling-discard.patch).
> 
> I walked around it with the following patch.
> 
> diff --git a/fs/btrfs/discard.c b/fs/btrfs/discard.c
> index 98bce18..9ffe5c4 100644
> --- a/fs/btrfs/discard.c
> +++ b/fs/btrfs/discard.c
> @@ -7,6 +7,7 @@
>   #include <linux/math64.h>
>   #include <linux/sizes.h>
>   #include <linux/workqueue.h>
> +#include "messages.h"
>   #include "ctree.h"
>   #include "block-group.h"
>   #include "discard.h"

I think you should send this as a formal patch to the stable list.

Thanks,
Qu

> 
> 
> Best Regards
> Wang Yugui (wangyugui@e16-tech.com)
> 2025/05/26
> 
> 
>