From: Qu Wenruo <wqu@suse.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH] btrfs-progs: tests/misc/058: reduce the space requirement and speed up the test
Date: Tue, 8 Aug 2023 14:55:21 +0800 [thread overview]
Message-ID: <173e7faa9202a5d3438cd5bbdca765708f3bc729.1691477705.git.wqu@suse.com> (raw)
[BUG]
When I was testing misc/058, the fs still has around 7GiB free space,
but during that test case, btrfs kernel module reports write failures
and even git commands failed inside that fs.
And obviously the test case failed.
[CAUSE]
It turns out that, the test case itself would require 6GiB (4 data
disks) + 1.5GiB x 2 (the two replace target), thus it requires 9 GiB
free space.
And obviously my partition is not that large and failed.
[FIX]
In fact, we really don't need that much space at all.
Our objective is to test "btrfs device replace --enqueue" functionality,
there is not much need to wait for 1 second, we can just do the enqueue
immediately.
So this patch would reduce the file size to a more sane (and rounded)
2GiB, and do the enqueue immediately.
Signed-off-by: Qu Wenruo <wqu@suse.com>
---
tests/misc-tests/058-replace-start-enqueue/test.sh | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/tests/misc-tests/058-replace-start-enqueue/test.sh b/tests/misc-tests/058-replace-start-enqueue/test.sh
index 1a24d5ec7ecb..bdbc87b4090d 100755
--- a/tests/misc-tests/058-replace-start-enqueue/test.sh
+++ b/tests/misc-tests/058-replace-start-enqueue/test.sh
@@ -21,16 +21,15 @@ run_check_mount_test_dev
run_check $SUDO_HELPER "$TOP/btrfs" device remove "$REPLACE1" "$TEST_MNT"
run_check $SUDO_HELPER "$TOP/btrfs" device remove "$REPLACE2" "$TEST_MNT"
-for i in `seq 48`; do
+for i in `seq 16`; do
run_check $SUDO_HELPER dd if=/dev/zero of="$TEST_MNT/file$i" bs=1M count=128 status=noxfer
done
# Sync so replace start does not block in unwritten IO
run_check "$TOP/btrfs" filesystem sync "$TEST_MNT"
run_check "$TOP/btrfs" filesystem usage -T "$TEST_MNT"
-# Go background, should not be that fast, estimated 10 seconds
+# Go background, should not be that fast.
run_check $SUDO_HELPER "$TOP/btrfs" replace start 2 "$REPLACE1" "$TEST_MNT"
-run_check sleep 1
# No background, should wait
run_check $SUDO_HELPER "$TOP/btrfs" replace start --enqueue 3 "$REPLACE2" "$TEST_MNT"
run_check $SUDO_HELPER "$TOP/btrfs" replace status "$TEST_MNT"
--
2.41.0
next reply other threads:[~2023-08-08 17:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-08 6:55 Qu Wenruo [this message]
2023-08-09 12:26 ` [PATCH] btrfs-progs: tests/misc/058: reduce the space requirement and speed up the test David Sterba
2023-08-09 12:35 ` David Sterba
2023-08-10 1:06 ` Qu Wenruo
2023-08-10 14:22 ` David Sterba
2023-08-09 13:20 ` Josef Bacik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173e7faa9202a5d3438cd5bbdca765708f3bc729.1691477705.git.wqu@suse.com \
--to=wqu@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).