From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailsec112.isp.belgacom.be ([195.238.20.108]:38576 "EHLO mailsec112.isp.belgacom.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751348AbaGQShg convert rfc822-to-8bit (ORCPT ); Thu, 17 Jul 2014 14:37:36 -0400 Date: Thu, 17 Jul 2014 20:37:34 +0200 (CEST) From: Fabian Frederick Reply-To: Fabian Frederick To: Zach Brown Cc: Josef Bacik , linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org, Chris Mason Message-ID: <1762701571.679094.1405622254558.open-xchange@webmail.nmp.skynet.be> In-Reply-To: <20140716172021.GA10833@lenny.home.zabbo.net> References: <1405451837-8235-1-git-send-email-fabf@skynet.be> <20140716172021.GA10833@lenny.home.zabbo.net> Subject: Re: [PATCH 1/1] Btrfs: fix sparse warning MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-btrfs-owner@vger.kernel.org List-ID: > On 16 July 2014 at 19:20 Zach Brown wrote: > > > On Tue, Jul 15, 2014 at 09:17:17PM +0200, Fabian Frederick wrote: > > Fix the following sparse warning: > > fs/btrfs/send.c:518:51: warning: incorrect type in argument 2 (different > > address spaces) > > fs/btrfs/send.c:518:51:    expected char const [noderef] * > > fs/btrfs/send.c:518:51:    got char * > > > > We can safely use (const char __user *) with set_fs(KERNEL_DS) > > Yeah, that cast is correct. > > Reviewed-by: Zach Brown > > > @@ -515,7 +515,8 @@ static int write_buf(struct file *filp, const void *buf, > > u32 len, loff_t *off) > > Though this probably wants to be rewritten in terms of kernel_write(). > That'd give an opportunity to get rid of the sctx->send_off and have it > use f_pos in the filp. Do you mean directly call kernel_write from send_cmd/send_header ? I guess that loop around vfs_write in write_buf is there for something ... Fabian > > - z