From: chandan <chandan@linux.vnet.ibm.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com, linux-btrfs@vger.kernel.org,
sekharan@linux.vnet.ibm.com
Subject: Re: [PATCH] _test_generic_punch: Extend $testfile's size to work with 64k block.
Date: Tue, 13 Aug 2013 21:28:06 +0530 [thread overview]
Message-ID: <1795219.CLAn9GhObP@localhost.localdomain> (raw)
In-Reply-To: <20130812011155.GL12779@dastard>
Hello Dave,
> So, to do this properly, I'd suggest that the code needs to scale
> the offset/size of the IO being done by the filesystem block size,
> not use a fixed size. Using a filter on the bmap output to handle
> the different block ranges will ensure everything works correctly
> from a golden output POV, except for one thing - the md5sum.
>
Yes, we did try the approach of using variable block size and scaling
the offset values in the filter function. But we got stuck
working with md5sum (since we would need two sets of md5sums (with and
without '-k' option) per block size). As suggested, I will be
reposting the patch to use "_requires_le_4k_blocksize".
chandan
prev parent reply other threads:[~2013-08-13 15:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-08 6:10 [PATCH] _test_generic_punch: Extend $testfile's size to work with 64k block chandan
2013-08-12 1:11 ` Dave Chinner
2013-08-13 15:58 ` chandan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1795219.CLAn9GhObP@localhost.localdomain \
--to=chandan@linux.vnet.ibm.com \
--cc=david@fromorbit.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=sekharan@linux.vnet.ibm.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).