From: Chandan Rajendra <chandan@linux.vnet.ibm.com>
To: Josef Bacik <jbacik@fb.com>
Cc: linux-btrfs@vger.kernel.org, clm@fb.com, bo.li.liu@oracle.com,
dsterba@suse.cz, quwenruo@cn.fujitsu.com, chandan@mykolab.com,
jpa@semihalf.com
Subject: Re: [PATCH V5 12/13] Btrfs: prepare_pages: Retry adding a page to the page cache
Date: Fri, 02 Oct 2015 17:54:19 +0530 [thread overview]
Message-ID: <1796383.HbmoRglGMS@localhost.localdomain> (raw)
In-Reply-To: <560D4836.8020301@fb.com>
On Thursday 01 Oct 2015 10:50:30 Josef Bacik wrote:
> On 09/30/2015 06:28 AM, Chandan Rajendra wrote:
> > When reading the page from the disk, we can race with Direct I/O which can
> > get the page lock (before prepare_uptodate_page() gets it) and can go
> > ahead and invalidate the page. Hence if the page is not found in the
> > inode's address space, retry the operation of getting a page.
> >
> > Signed-off-by: Chandan Rajendra <chandan@linux.vnet.ibm.com>
> > ---
>
> Huh, how in the world did you make that happen?
>
The issue is seen when generic/095 test is run in a loop. I would like to add,
Reported-by: Jakub Palider <jpa@semihalf.com>
> Reviewed-by: Josef Bacik <jbacik@fb.com>
>
> Thanks,
>
> Josef
--
chandan
next prev parent reply other threads:[~2015-10-02 12:25 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-30 10:28 [PATCH V5 00/13] Btrfs: Pre subpagesize-blocksize cleanups Chandan Rajendra
2015-09-30 10:28 ` [PATCH V5 01/13] Btrfs: __btrfs_buffered_write: Reserve/release extents aligned to block size Chandan Rajendra
2015-10-01 14:37 ` Josef Bacik
2015-09-30 10:28 ` [PATCH V5 02/13] Btrfs: Compute and look up csums based on sectorsized blocks Chandan Rajendra
2015-10-01 14:39 ` Josef Bacik
2015-10-02 12:20 ` Chandan Rajendra
2015-09-30 10:28 ` [PATCH V5 03/13] Btrfs: Direct I/O read: Work " Chandan Rajendra
2015-09-30 10:28 ` [PATCH V5 04/13] Btrfs: fallocate: Work with " Chandan Rajendra
2015-09-30 10:28 ` [PATCH V5 05/13] Btrfs: btrfs_page_mkwrite: Reserve space in sectorsized units Chandan Rajendra
2015-09-30 10:28 ` [PATCH V5 06/13] Btrfs: Search for all ordered extents that could span across a page Chandan Rajendra
2015-09-30 10:28 ` [PATCH V5 07/13] Btrfs: Use (eb->start, seq) as search key for tree modification log Chandan Rajendra
2015-09-30 10:28 ` [PATCH V5 08/13] Btrfs: btrfs_submit_direct_hook: Handle map_length < bio vector length Chandan Rajendra
2015-09-30 10:28 ` [PATCH V5 09/13] Btrfs: Limit inline extents to root->sectorsize Chandan Rajendra
2015-09-30 10:28 ` [PATCH V5 10/13] Btrfs: Fix block size returned to user space Chandan Rajendra
2015-10-01 14:58 ` Josef Bacik
2015-09-30 10:28 ` [PATCH V5 11/13] Btrfs: Clean pte corresponding to page straddling i_size Chandan Rajendra
2015-10-01 14:57 ` Josef Bacik
2015-10-02 16:34 ` Chandan Rajendra
2015-09-30 10:28 ` [PATCH V5 12/13] Btrfs: prepare_pages: Retry adding a page to the page cache Chandan Rajendra
2015-10-01 14:50 ` Josef Bacik
2015-10-02 12:24 ` Chandan Rajendra [this message]
2015-09-30 10:28 ` [PATCH V5 13/13] Btrfs: Return valid delalloc range when the page does not have PG_Dirty flag set or has been invalidated Chandan Rajendra
2015-10-01 14:48 ` Josef Bacik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1796383.HbmoRglGMS@localhost.localdomain \
--to=chandan@linux.vnet.ibm.com \
--cc=bo.li.liu@oracle.com \
--cc=chandan@mykolab.com \
--cc=clm@fb.com \
--cc=dsterba@suse.cz \
--cc=jbacik@fb.com \
--cc=jpa@semihalf.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).