From: Qu Wenruo <wqu@suse.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH v4 1/2] btrfs: Move on-disk structure definition to btrfs_tree.h
Date: Tue, 21 Apr 2020 19:41:40 +0800 [thread overview]
Message-ID: <18832f69-073f-ef74-5ec7-3de06df466df@suse.com> (raw)
In-Reply-To: <20200421113138.GA10447@infradead.org>
On 2020/4/21 下午7:31, Christoph Hellwig wrote:
> On Wed, Apr 15, 2020 at 04:41:12PM +0800, Qu Wenruo wrote:
>> These structures all are on-disk format. Move them to btrfs_tree.h
>>
>> This allows us to sync the header to different projects, who need to
>> read btrfs filesystem, like U-boot, grub.
>
> Please use a separate header for that. btrfs_tree.h is a UAPI header
> with strict ABI guarantees. Just add a fs/btrfs/btrfs_format.h that
> can be copied into the projects where is needed.
>
Doesn't on-disk format itself need strict ABI guarantees?
Thus it looks like the perfect location for on-disk format definitions.
Thanks,
Qu
next prev parent reply other threads:[~2020-04-21 11:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 8:41 [PATCH v4 0/2] btrfs: Reformat and make btrfs_tree.h self-contained Qu Wenruo
2020-04-15 8:41 ` [PATCH v4 1/2] btrfs: Move on-disk structure definition to btrfs_tree.h Qu Wenruo
2020-04-21 11:31 ` Christoph Hellwig
2020-04-21 11:41 ` Qu Wenruo [this message]
2020-04-24 20:24 ` David Sterba
2020-04-25 7:14 ` Christoph Hellwig
2020-04-25 7:25 ` Qu Wenruo
2020-04-30 7:29 ` Qu Wenruo
2020-04-23 11:32 ` kbuild test robot
2020-04-15 8:41 ` [PATCH v4 2/2] btrfs: Reformat btrfs_tree.h comments Qu Wenruo
2020-04-16 10:20 ` David Sterba
2020-04-16 12:54 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18832f69-073f-ef74-5ec7-3de06df466df@suse.com \
--to=wqu@suse.com \
--cc=hch@infradead.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).