Re: [PATCH v2] btrfs-progs: btrfsutil: add pkg-config files for btrfsutil

[Sheng Mao <shngmao@gmail.com>]

On 2020-10-02 11:54 a.m., David Sterba wrote:
> On Wed, Aug 19, 2020 at 10:36:18PM -0600, Sheng Mao wrote:
>> Add pc file for btrfsutil libraries. Users can use
>> pkg-config to set up compilation and linking flags.
>>
>> The paths in pc file depend on prefix variable but
>> ignore DESTDIR. DESTDIR is used for packaging and
>> it should not affect the paths in pc file.
>>
>> Signed-off-by: Sheng Mao <shngmao@gmail.com>
> 
> Thanks, I've added it to devel.
> 
>> +test-pkg-config:
>> +	@echo "Test pkg-config settings"
>> +	export libdir incdir
>> +	$(Q)bash tests/pkg-config-tests.sh
> 
> I've deleted this section and the script, there's no point testing it
> like that.
> 
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -12,6 +12,10 @@ LIBBTRFS_MAJOR=0
>>   LIBBTRFS_MINOR=1
>>   LIBBTRFS_PATCHLEVEL=2
>>   
>> +BTRFS_UTIL_VERSION_MAJOR=1
>> +BTRFS_UTIL_VERSION_MINOR=2
>> +BTRFS_UTIL_VERSION_PATCH=0
> 
> This would duplicate the version definition, so this needs to parse it
> from libbtrfsutil/btrfsutil.h.
> 

Hi David,

Thank you for reviewing and merging the code! I agree with you, the test 
code doesn't make sense and it is right to remove it.

Also, thank you Neal for helping me improving the patch!

Thank you!

Regards,
Sheng