Re: [PATCH] btrfs-progs: receive: fix unused variable warning without LZO

[Qu Wenruo <quwenruo.btrfs@gmx.com>]

在 2026/9/29 16:44, liuh0329 写道:
> When btrfs-progs is built without LZO support, sector_shift is still
> declared in decompress_and_write(), while all its uses are guarded by
> COMPRESSION_LZO. This results in an unused variable warning.
> 
> Guard the declaration with COMPRESSION_LZO as well.

Just move the declaration to the only usage.

That makes more sense than introducing new #if block.
> 
> Fixes: 345731fff32d ("btrfs-progs: receive: optional build for lzo, zstd")
> Signed-off-by: liuh0329 <liuhuan01@kylinos.cn>
> ---
>   cmds/receive.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/cmds/receive.c b/cmds/receive.c
> index 49103ea3..14a9ba03 100644
> --- a/cmds/receive.c
> +++ b/cmds/receive.c
> @@ -1186,7 +1186,9 @@ static int decompress_and_write(struct btrfs_receive *rctx,
>   {
>   	int ret = 0;
>   	char *unencoded_data;
> +#if COMPRESSION_LZO
>   	int sector_shift = 0;
> +#endif
>   	u64 written = 0;
>   
>   	unencoded_data = calloc(unencoded_len, 1);