From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from aserp1040.oracle.com ([141.146.126.69]:25242 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753289AbdJPXch (ORCPT ); Mon, 16 Oct 2017 19:32:37 -0400 Subject: Re: [PATCH] btrfs: remove BUG_ON in btrfs_rm_dev_replace_free_srcdev() To: dsterba@suse.cz, linux-btrfs@vger.kernel.org References: <20171012090041.7438-1-anand.jain@oracle.com> <20171016144547.GR3521@twin.jikos.cz> From: Anand Jain Message-ID: <1e283cba-2dc1-b404-f826-20da80cf880b@oracle.com> Date: Tue, 17 Oct 2017 07:32:23 +0800 MIME-Version: 1.0 In-Reply-To: <20171016144547.GR3521@twin.jikos.cz> Content-Type: text/plain; charset=utf-8; format=flowed Sender: linux-btrfs-owner@vger.kernel.org List-ID: On 10/16/2017 10:45 PM, David Sterba wrote: > On Thu, Oct 12, 2017 at 05:00:41PM +0800, Anand Jain wrote: >> That was only an extra check to tackle few bugs around this >> area, now its save to remove it. >> >> Signed-off-by: Anand Jain >> --- >> fs/btrfs/volumes.c | 8 ++------ >> 1 file changed, 2 insertions(+), 6 deletions(-) >> >> diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c >> index 332e00e72b86..0a5251a34d58 100644 >> --- a/fs/btrfs/volumes.c >> +++ b/fs/btrfs/volumes.c >> @@ -2015,16 +2015,12 @@ void btrfs_rm_dev_replace_free_srcdev(struct btrfs_fs_info *fs_info, >> } >> >> btrfs_close_bdev(srcdev); >> - >> call_rcu(&srcdev->rcu, free_device); >> >> /* >> - * unless fs_devices is seed fs, num_devices shouldn't go >> - * zero >> + * If this is no devs we rather delete the fs_devices >> + * which is true in case of single device seeding fs. > > Can you please rephrase the first part of the comment? I'm not sure I > understand what it's trying to say. > >> */ >> - BUG_ON(!fs_devices->num_devices && !fs_devices->seeding); > > I think we could still keep the check as an ASSERT. OK. I have fixed these in V2. Thanks, Anand >> - >> - /* if this is no devs we rather delete the fs_devices */ >> if (!fs_devices->num_devices) { >> struct btrfs_fs_devices *tmp_fs_devices; >>