From: Anand Jain <anand.jain@oracle.com>
To: dsterba@suse.cz, linux-btrfs@vger.kernel.org
Cc: Nikolay Borisov <nborisov@suse.com>
Subject: Re: [PATCH 3/4 RESEND] btrfs: open code btrfs_set_prop in inherit_prop
Date: Wed, 3 Apr 2019 08:42:01 +0800 [thread overview]
Message-ID: <1e788d95-c423-c863-e4d0-758848d25bc5@oracle.com> (raw)
In-Reply-To: <20190402232447.GK29086@twin.jikos.cz>
On 3/4/19 7:24 AM, David Sterba wrote:
> On Tue, Apr 02, 2019 at 04:35:12PM +0300, Nikolay Borisov wrote:
>>> @@ -367,20 +367,35 @@ static int inherit_props(struct btrfs_trans_handle *trans,
>>> if (!value)
>>> continue;
>>>
>>> + /* may be removed */
>>
>> This comment brings no value. Either explain *why* it can be removed or
>> remove it altogether.
>
> Comment replaced by
>
> /*
> * This is not strictly necessary as the property should be
> * valid, but in case it isn't, don't propagate it futher.
> */
>
> I'd keep it the because that's what the direct opencoding transformation would
> do. If we want to remove it, then the reasoning should be provided.
Agreed with the reasoning.
Thanks, Anand
next prev parent reply other threads:[~2019-04-03 0:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-02 10:07 [PATCH 0/4 RESEND] btrfs: fix property bugs Anand Jain
2019-04-02 10:07 ` [PATCH 1/4 RESEND] btrfs: fix zstd compression parameter Anand Jain
2019-04-02 22:09 ` David Sterba
2019-04-02 10:07 ` [PATCH] fstests: btrfs/048: amend property validation cases Anand Jain
2019-04-02 12:51 ` Nikolay Borisov
2019-04-03 0:32 ` Anand Jain
2019-04-02 10:07 ` [PATCH 2/4 RESEND] btrfs: fix vanished compression property after failed set Anand Jain
2019-04-02 13:00 ` Nikolay Borisov
2019-04-02 22:14 ` David Sterba
2019-04-02 10:07 ` [PATCH 3/4 RESEND] btrfs: open code btrfs_set_prop in inherit_prop Anand Jain
2019-04-02 13:35 ` Nikolay Borisov
2019-04-02 21:41 ` David Sterba
2019-04-02 23:24 ` David Sterba
2019-04-03 0:42 ` Anand Jain [this message]
2019-04-02 21:41 ` David Sterba
2019-04-02 10:07 ` [PATCH 4/4 RESEND] btrfs: fix property validate fail should not increment generation Anand Jain
2019-04-02 13:45 ` Nikolay Borisov
2019-04-02 21:13 ` David Sterba
2019-04-02 22:04 ` David Sterba
2019-04-02 23:03 ` Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e788d95-c423-c863-e4d0-758848d25bc5@oracle.com \
--to=anand.jain@oracle.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).