From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>,
Li Zhang <zhanglikernel@gmail.com>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] Make btrfs_prepare_device parallel during mkfs.btrfs
Date: Thu, 25 Aug 2022 16:36:16 +0800 [thread overview]
Message-ID: <1ff7ddcb-0a95-d023-d346-e86cc6195afd@gmx.com> (raw)
In-Reply-To: <PH0PR04MB7416B660C501F73F47E7D4159B729@PH0PR04MB7416.namprd04.prod.outlook.com>
On 2022/8/25 16:31, Johannes Thumshirn wrote:
> On 25.08.22 07:20, Qu Wenruo wrote:
>>> + if (zoned && zoned_model(file) == ZONED_HOST_MANAGED)
>>> + prepare_ctx[i].oflags = O_RDWR | O_DIRECT;
>> Do we need to treat the initial and other devices differently?
>>
>> Can't we use the same flags for all devices?
>>
>>
>
> Yep we need to have the same flags for all devices. Otherwise only
> device 0 will be opened with O_DIRECT, in case of a host-managed one and
> the subsequent will be opened without O_DIRECT causing mkfs to fail.
Just a little curious, currently btrfs doesn't support mixed
traditional/zoned devices, right?
So that O_DIRECT for all devices are for future mixed zoned mode?
Anyway I'm completely fine if we can use the same oflags for all devices.
Thanks,
Qu
next prev parent reply other threads:[~2022-08-25 8:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-24 16:05 [PATCH] Make btrfs_prepare_device parallel during mkfs.btrfs Li Zhang
2022-08-25 5:20 ` Qu Wenruo
2022-08-25 8:31 ` Johannes Thumshirn
2022-08-25 8:36 ` Qu Wenruo [this message]
2022-08-25 8:40 ` Johannes Thumshirn
2022-08-28 8:53 ` li zhang
2022-08-28 9:54 ` Qu Wenruo
2022-08-28 14:26 ` li zhang
2022-08-28 14:33 ` li zhang
2022-08-29 0:36 ` Qu Wenruo
2022-08-25 8:33 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ff7ddcb-0a95-d023-d346-e86cc6195afd@gmx.com \
--to=quwenruo.btrfs@gmx.com \
--cc=Johannes.Thumshirn@wdc.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=zhanglikernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox