From: Jens Axboe <jens.axboe@oracle.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: Chris Mason <chris.mason@oracle.com>, linux-btrfs@vger.kernel.org
Subject: Re: Multi-device update
Date: Wed, 16 Apr 2008 20:14:38 +0200 [thread overview]
Message-ID: <20080416181438.GM12774@kernel.dk> (raw)
In-Reply-To: <48064114.5080304@firstfloor.org>
On Wed, Apr 16 2008, Andi Kleen wrote:
> Chris Mason wrote:
> > On Wednesday 16 April 2008, Andi Kleen wrote:
> >> Chris Mason <chris.mason@oracle.com> writes:
> >>> On Wednesday 16 April 2008, Andi Kleen wrote:
> >>>> Chris Mason <chris.mason@oracle.com> writes:
> >>>>> The async work queues include code to checksum data pages without the
> >>>>> FS mutex
> >>>> Are they able to distribute work to other cores?
> >>> Yes, it just uses a workqueue.
> >> Unfortunately work queues don't do that by default currently. They
> >> tend to process on the current CPU only.
> >
> > Well, I see multiple work queue threads using CPU time, but I haven't spent
> > much time optimizing it. There's definitely room for improvement.
>
> That's likely because you submit from multiple CPUs. But with a single
> submitter running on a single CPU there shouldn't be any load balancing
> currently.
There have been various implementations of queue_work_on() posted
through the years, I've had one version that I've used off and on for a
long time:
http://git.kernel.dk/?p=linux-2.6-block.git;a=commit;h=c68c42fd6df96f5b3fb5b8b47c571f233d054c71
then you need some balancing decider on top of that, of course.
--
Jens Axboe
next prev parent reply other threads:[~2008-04-16 18:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-16 15:34 Multi-device update Chris Mason
2008-04-16 16:14 ` Andi Kleen
2008-04-16 16:54 ` Chris Mason
2008-04-16 17:43 ` Andi Kleen
2008-04-16 18:04 ` Chris Mason
2008-04-16 18:10 ` Andi Kleen
2008-04-16 18:14 ` Jens Axboe [this message]
2008-04-16 18:24 ` Andi Kleen
2008-04-16 18:26 ` Jens Axboe
2008-04-16 18:28 ` Chris Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080416181438.GM12774@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=andi@firstfloor.org \
--cc=chris.mason@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).