From: Christoph Hellwig <hch@infradead.org>
To: Josef Bacik <jbacik@redhat.com>
Cc: Balaji Rao R <balajirrao@gmail.com>, linux-btrfs@vger.kernel.org
Subject: Re: [RFC] NFS Support
Date: Tue, 1 Jul 2008 03:01:56 -0400 [thread overview]
Message-ID: <20080701070156.GA26299@infradead.org> (raw)
In-Reply-To: <20080630150811.GB18866@unused.rdu.redhat.com>
On Mon, Jun 30, 2008 at 11:08:11AM -0400, Josef Bacik wrote:
> > >>
> > >> spin_unlock(&dentry->d_lock);
> > >>
> > >> len += 3;
> > >
> > > there is no need to take the d_lock here.
> > OK. Will remove it. It was done at fs/ocfs2/export.c. So probably i
> > thought it was necessary.
> >
> > <snip>
> >
>
> Ahh see this is where me not being familiar with NFS gets me in trouble, you do
> need the d_lock in that case. Sorry about that.
It's not really about nfs, dereferencing ->d_parent needs d_lock.
next prev parent reply other threads:[~2008-07-01 7:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-28 23:35 [RFC] NFS Support Balaji Rao
2008-06-30 14:50 ` Josef Bacik
2008-06-30 15:20 ` Balaji Rao R
2008-06-30 15:08 ` Josef Bacik
2008-07-01 7:01 ` Christoph Hellwig [this message]
2008-06-30 18:46 ` Christoph Hellwig
2008-08-12 13:46 ` [PATCH 1/3] Introduce btrfs_iget helper David Woodhouse
2008-08-12 18:46 ` Christoph Hellwig
2008-08-13 9:07 ` David Woodhouse
2008-08-13 9:41 ` David Woodhouse
2008-08-12 13:46 ` [PATCH 2/3] NFS support for btrfs - v2 David Woodhouse
2008-08-12 18:51 ` Christoph Hellwig
2008-08-13 8:53 ` David Woodhouse
2008-08-13 15:06 ` [PATCH 2/3] NFS support for btrfs - v3 David Woodhouse
2008-08-12 13:46 ` [PATCH 3/3] Implement our own copy of the nfsd readdir hack, for older kernels David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080701070156.GA26299@infradead.org \
--to=hch@infradead.org \
--cc=balajirrao@gmail.com \
--cc=jbacik@redhat.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox