From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andi Kleen Subject: Re: [PATCH -v7][RFC]: mutex: implement adaptive spinning Date: Sat, 10 Jan 2009 04:02:16 +0100 Message-ID: <20090110030216.GW26290@one.firstfloor.org> References: <20090109204103.GA17212@elte.hu> <20090109213442.GA20051@elte.hu> <1231537320.5726.2.camel@brick> <20090109231227.GA25070@elte.hu> <20090110010125.GA31031@elte.hu> <20090109174158.096dee70.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Ingo Molnar , Linus Torvalds , Harvey Harrison , "H. Peter Anvin" , Andi Kleen , Chris Mason , Peter Zijlstra , Steven Rostedt , paulmck@linux.vnet.ibm.com, Gregory Haskins , Matthew Wilcox , Linux Kernel Mailing List , linux-fsdevel , linux-btrfs , Thomas Gleixner , Nick Piggin , Peter Morreale , Sven Dietrich To: Andrew Morton Return-path: In-Reply-To: <20090109174158.096dee70.akpm@linux-foundation.org> List-ID: > A side-effect of the inline fetish is that a lot of it goes into header > files, thus requiring that those header files #include lots of other > headers, thus leading to, well, the current mess. I personally also always found it annoying while grepping that part of the code is in a completely different directory. e.g. try to go through TCP code without jumping to .hs all the time. Long term that problem will hopefully disappear, as gcc learns to do cross source file inlining (like a lot of other compilers already do) -Andi -- ak@linux.intel.com