Re: [PATCH -v7][RFC]: mutex: implement adaptive spinning

Harvey Harrison
2009-01-09T02:24:56Z

On Thu, 2009-01-08 at 17:44 -0800, H. Peter Anvin wrote:
> Harvey Harrison wrote:
> >>
> >> We might still try the second or third options, as i think we shouldnt go
> >> back into the business of managing the inline attributes of ~100,000
> >> kernel functions.
> >
> > Or just make it clear that inline shouldn't (unless for a very good reason)
> > _ever_ be used in a .c file.
> >
>
> The question is if that would produce acceptable quality code. In
> theory it should, but I'm more than wondering if it really will.
>
> It would be ideal, of course, as it would mean less typing. I guess we
> could try it out by disabling any "inline" in the current code that
> isn't "__always_inline"...
>

A lot of code was written assuming inline means __always_inline, I'd suggest
keeping that assumption and working on removing inlines that aren't
strictly necessary as there's no way to know what inlines meant 'try to inline'
and what ones really should have been __always_inline.

Not that I feel _that_ strongly about it.

Cheers,

Harvey