Linux Btrfs filesystem development
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@linux.intel.com>
To: David Woodhouse <david.woodhouse@intel.com>
Cc: Ric Wheeler <rwheeler@redhat.com>,
	Erwin van Londen <erwin.vanlonden@hds.com>,
	"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
	Alasdair G Kergon <agk@redhat.com>,
	James Bottomley <JBottomley@Novell.com>,
	Tom Coughlan <coughlan@redhat.com>
Subject: Re: btrfs for enterprise raid arrays
Date: Fri, 3 Apr 2009 06:27:39 -0700	[thread overview]
Message-ID: <20090403132739.GU2661@linux.intel.com> (raw)
In-Reply-To: <1238759880.3494.5.camel@macbook.infradead.org>

On Fri, Apr 03, 2009 at 12:58:00PM +0100, David Woodhouse wrote:
> On Fri, 2009-04-03 at 12:43 +0100, Ric Wheeler wrote:
> > > New firmware/microcode versions are able to reclaim that space if it
> > > sees a certain number of consecutive zero's and will reclaim that 
> > > space to the volume pool. Are there any thoughts on writing a 
> > > low-priority tread that zeros out those "non-used" blocks?
> > 
> > Patches have been floating around to support this - see the recent 
> > patches around "DISCARD" on linux-ide and lkml.  It would be great to 
> > get access to a box that implemented the T10 proposed UNMAP commands 
> > that we could test against. 
> 
> We've already made btrfs support TRIM, and Matthew has patches which
> hook it up for ATA/IDE devices. Adding SCSI support shouldn't be hard
> once the dust settles on the spec.

It seems like the dust has settled ... I just need to check that
my code still conforms to the spec.  Understandably, I've been focused
on TRIM ;-)

> I don't think I've seen anybody talking about deliberately writing
> zeroes instead of just issuing a discard command though. That doesn't
> seem like a massively cunning plan.

Yeah, WRITE SAME with the discard bit.  A bit of a crappy way to go, to
be sure.  I'm not exactly sure how we're supposed to be deciding whether
to issue an UNMAP or WRITE SAME command.  Perhaps if I read the spec
properly it'll tell me.

I just had a quick chat with someone from another storage vendor who
don't yet implement UNMAP -- if you do a WRITE SAME with all zeroes,
their device will notice that and unmap the LBAs in question.

Something for the plane on Sunday anyway.

  parent reply	other threads:[~2009-04-03 13:27 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-03  4:34 btrfs for enterprise raid arrays Erwin van Londen
2009-04-03  7:32 ` Sander
2009-04-03 11:51   ` Ric Wheeler
2009-04-03 11:43 ` Ric Wheeler
2009-04-03 11:58   ` David Woodhouse
2009-04-03 12:02     ` Ric Wheeler
2009-04-03 13:27     ` Matthew Wilcox [this message]
2009-04-03 13:48       ` James Bottomley
2009-04-03 13:51   ` James Bottomley
2009-04-03 13:22 ` Chris Mason
2009-04-06  0:29   ` Erwin van Londen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090403132739.GU2661@linux.intel.com \
    --to=willy@linux.intel.com \
    --cc=JBottomley@Novell.com \
    --cc=agk@redhat.com \
    --cc=coughlan@redhat.com \
    --cc=david.woodhouse@intel.com \
    --cc=erwin.vanlonden@hds.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=rwheeler@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox