From: Chris Mason <chris.mason@oracle.com>
To: Hisashi Hifumi <hifumi.hisashi@oss.ntt.co.jp>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] Btrfs: fdatasync should skip metadata writeout
Date: Mon, 8 Jun 2009 10:01:20 -0400 [thread overview]
Message-ID: <20090608140120.GC3899@think> (raw)
In-Reply-To: <6.0.0.20.2.20090608133848.0740d758@172.19.0.2>
On Mon, Jun 08, 2009 at 04:50:47PM +0900, Hisashi Hifumi wrote:
> Hi.
>
> In btrfs, fdatasync and fsync are identical.
> I think fdatasync should skip committing transaction when
> inode->i_state is set just I_DIRTY_SYNC and this indicates
> only atime or/and mtime updates.
> Following patch improves fdatasync throughput.
>
> #sysbench --num-threads=16 --max-requests=10000 --test=fileio
> --file-block-size=4K --file-total-size=16G --file-test-mode=rndwr
> --file-fsync-mode=fdatasync run
Very nice, thank you for the patch.
-chris
prev parent reply other threads:[~2009-06-08 14:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-08 7:50 [PATCH] Btrfs: fdatasync should skip metadata writeout Hisashi Hifumi
2009-06-08 14:01 ` Chris Mason [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090608140120.GC3899@think \
--to=chris.mason@oracle.com \
--cc=hifumi.hisashi@oss.ntt.co.jp \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox