From: Chris Mason <chris.mason@oracle.com>
To: Yan Zheng <zheng.yan@oracle.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] Always update root items for fs trees at commit time
Date: Mon, 15 Jun 2009 09:26:03 -0400 [thread overview]
Message-ID: <20090615132603.GB4712@think> (raw)
In-Reply-To: <4A364B17.9030609@oracle.com>
On Mon, Jun 15, 2009 at 09:22:31PM +0800, Yan Zheng wrote:
> commit_fs_roots skips updating root items for fs trees that aren't modified.
> This is unsafe since relocation code modifies root item's last_snapshot field
> without modifying corresponding fs tree.
Thanks for working on these patches.
This could make commit pretty expensive when there are many snapshots in
place that don't get modified. Could you please change the balance code
to mark the root to force writeout?
-chris
prev parent reply other threads:[~2009-06-15 13:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-15 13:22 [PATCH] Always update root items for fs trees at commit time Yan Zheng
2009-06-15 13:26 ` Chris Mason [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090615132603.GB4712@think \
--to=chris.mason@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=zheng.yan@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox