From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 1/2] btrfs: enable discard support Date: Wed, 14 Oct 2009 15:32:03 +0200 Message-ID: <20091014133203.GA14011@lst.de> References: <20091014010302.GA21031@lst.de> <20091014132704.GG7850@think> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii To: Chris Mason , Christoph Hellwig , linux-btrfs@vger.kernel.org Return-path: In-Reply-To: <20091014132704.GG7850@think> List-ID: On Wed, Oct 14, 2009 at 09:27:04AM -0400, Chris Mason wrote: > On Wed, Oct 14, 2009 at 03:03:02AM +0200, Christoph Hellwig wrote: > > The discard support code in btrfs currently is guarded by ifdefs for > > BIO_RW_DISCARD, which is never defines as it's the name of an enum > > memeber. Just remove the useless ifdefs to actually enable the code. > > Thanks Christoph, > > Any objection to me reordering these? That way someone bisecting around > won't hit discard support without expecting it. I'm perfectly fine with reordering them.