From: Andi Drebes <lists-receive@programmierforen.de>
To: linux-btrfs@vger.kernel.org
Cc: Chris Mason <chris.mason@oracle.com>
Subject: [PATCH] Prevent btrfsck to run on mounted filesystems
Date: Thu, 29 Oct 2009 21:52:15 +0100 [thread overview]
Message-ID: <200910292152.15564.lists-receive@programmierforen.de> (raw)
As recently discussed on the list, btrfsck should only be run on unmounted filesystems. This patch adds a short check for the mount status at the beginning of btrfsck. If the FS is mounted, the program aborts showing an error message.
Signed-off-by: Andi Drebes <lists-receive@programmierforen.de>
---
diff --git a/btrfsck.c b/btrfsck.c
index 73f1836..87ae776 100644
--- a/btrfsck.c
+++ b/btrfsck.c
@@ -28,6 +28,7 @@
#include "transaction.h"
#include "list.h"
#include "version.h"
+#include "utils.h"
static u64 bytes_used = 0;
static u64 total_csum_bytes = 0;
@@ -2819,6 +2820,16 @@ int main(int ac, char **av)
if (ac < 2)
print_usage();
+ ret = check_mounted(av[1]);
+ if (ret < 0) {
+ fprintf(stderr, "error checking %s mount status\n", av[1]);
+ return 1;
+ }
+ if (ret == 1) {
+ fprintf(stderr, "%s is mounted. btrfsck can only be run on an unmounted filesystem.\n", av[1]);
+ return 1;
+ }
+
radix_tree_init();
cache_tree_init(&root_cache);
root = open_ctree(av[1], 0, 0);
next reply other threads:[~2009-10-29 20:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-29 20:52 Andi Drebes [this message]
2009-10-30 5:02 ` [PATCH] Prevent btrfsck to run on mounted filesystems Christoph Hellwig
2009-10-30 13:05 ` Chris Mason
2009-10-31 20:46 ` Andi Drebes
2009-11-09 14:59 ` Andi Drebes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200910292152.15564.lists-receive@programmierforen.de \
--to=lists-receive@programmierforen.de \
--cc=chris.mason@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox