From: Chris Mason <chris.mason@oracle.com>
To: Josef Bacik <josef@redhat.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] Btrfs: add a "df" ioctl for btrfs
Date: Wed, 13 Jan 2010 09:31:00 -0500 [thread overview]
Message-ID: <20100113143100.GM14979@think> (raw)
In-Reply-To: <20100112202513.GA13414@localhost.localdomain>
On Tue, Jan 12, 2010 at 03:25:13PM -0500, Josef Bacik wrote:
> df is a very loaded question in btrfs. This gives us a way to get the per-space
> usage information so we can tell exactly what is in use where. This will help
> us figure out ENOSPC problems, and help users better understand where their disk
> space is going.
>
> diff --git a/fs/btrfs/ioctl.h b/fs/btrfs/ioctl.h
> index 9e5074c..850e0ee 100644
> --- a/fs/btrfs/ioctl.h
> +++ b/fs/btrfs/ioctl.h
> @@ -54,6 +54,18 @@ struct btrfs_ioctl_subvol_leaf {
> struct btrfs_ioctl_subvol_items items[];
> };
>
> +struct btrfs_ioctl_space_info {
> + u32 flags;
> + u64 total_bytes;
> + u64 used_bytes;
> +};
Could you please bump that u32 to a u64?
-chris
next prev parent reply other threads:[~2010-01-13 14:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-12 20:25 [PATCH] Btrfs: add a "df" ioctl for btrfs Josef Bacik
2010-01-12 20:34 ` Josef Bacik
2010-01-13 10:25 ` Christoph Hellwig
2010-01-13 13:33 ` Josef Bacik
2010-01-13 14:29 ` Chris Mason
2010-01-13 21:46 ` Christoph Hellwig
2010-01-14 0:55 ` Chris Mason
2010-01-13 14:31 ` Chris Mason [this message]
2010-01-13 18:19 ` Josef Bacik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100113143100.GM14979@think \
--to=chris.mason@oracle.com \
--cc=josef@redhat.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox