public inbox for linux-btrfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Josef Bacik <josef@redhat.com>
To: "Yan, Zheng " <yanzheng@21cn.com>
Cc: Josef Bacik <josef@redhat.com>, linux-btrfs@vger.kernel.org
Subject: Re: [RFC] make btrfs-image work
Date: Tue, 19 Jan 2010 21:37:36 -0500	[thread overview]
Message-ID: <20100120023736.GB16384@localhost.localdomain> (raw)
In-Reply-To: <3d0408631001191828v65fbb983w482f478b5ed92bbf@mail.gmail.com>

On Wed, Jan 20, 2010 at 10:28:01AM +0800, Yan, Zheng  wrote:
> On Wed, Jan 20, 2010 at 12:04 AM, Josef Bacik <josef@redhat.com> wrot=
e:
> > Hello,
> >
> > btrfs-image would be very helpful for debugging some users problems=
 that we
> > can't reproduce ourselves, but every image that i try and re-create=
 with
> > btrfs-image makes btrfs panic. =A0This is because we zero out the s=
uperblocks
> > chunk array and re-create our uuid. =A0This means that we end up no=
t being able to
> > read the chunk tree on mount, and then even if we could the uuid's =
of the
> > metadata we read back wouldn't match the uuid of the device. =A0The=
 way I've fixed
> > this is to just spit the metadata back onto the disk exactly the wa=
y we got it.
> > The caveat to this I think is that if we try to image a multi-devic=
e setup that
> > it won't work right unless we have a multi-device setup to restore =
the image
> > onto. =A0I'm not sure if thats the goal or not. =A0This patch makes=
 the single disk
> > case work fine for me. =A0Let me know what you think. =A0Thanks,
> >
>=20
> The goal of btrfs-image is create image that can be  examined by btrf=
sck and
> btrfs-debug-tree. btrfs-image creates metadata image for btrfs' logic=
al address
> space. So your patch only works for the uncommon case that btrfs' log=
ical
> address is mapped to offset of device.
>=20

Ok, but I think it would be helpful to be able to restore the fs onto a=
 device
and still be able to use it like a normal fs so we can debug other type=
s of
problems.  But I don't really care that much so if that wasn't the inte=
nded goal
I'll find something else to work on.  Thanks,

Josef
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" =
in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      reply	other threads:[~2010-01-20  2:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-19 16:04 [RFC] make btrfs-image work Josef Bacik
2010-01-20  2:28 ` Yan, Zheng 
2010-01-20  2:37   ` Josef Bacik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100120023736.GB16384@localhost.localdomain \
    --to=josef@redhat.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=yanzheng@21cn.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox