From: Chris Mason <chris.mason@oracle.com>
To: Shaohua Li <shaohua.li@intel.com>
Cc: Josef Bacik <josef@redhat.com>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] Btrfs: kill max_extent mount option
Date: Mon, 22 Mar 2010 09:25:06 -0400 [thread overview]
Message-ID: <20100322132506.GA32521@think> (raw)
In-Reply-To: <20100322013304.GA30742@sli10-desk.sh.intel.com>
On Mon, Mar 22, 2010 at 09:33:04AM +0800, Shaohua Li wrote:
> On Sat, Mar 20, 2010 at 02:07:23AM +0800, Josef Bacik wrote:
> > As Yan pointed out, theres not much reason for all this complicated math to
> > account for file extents being split up into max_extent chunks, since they are
> > likely to all end up in the same leaf anyway. Since there isn't much reason to
> > use max_extent, just remove the option altogether so we have one less thing we
> > need to test. Thanks,
> Since we sometimes have very big extents like several hundered mega bytes, just
> curious could removing max_extent limit cause more lock contentation for extent locks?
The default for the max_extent option is (u64)-1. So, in general it was
meant to force smaller extents as part of testing.
-chris
prev parent reply other threads:[~2010-03-22 13:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-19 18:07 [PATCH] Btrfs: kill max_extent mount option Josef Bacik
2010-03-22 1:33 ` Shaohua Li
2010-03-22 13:25 ` Chris Mason [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100322132506.GA32521@think \
--to=chris.mason@oracle.com \
--cc=josef@redhat.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).