From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Mason Subject: Re: [PATCH] Btrfs: kill max_extent mount option Date: Mon, 22 Mar 2010 09:25:06 -0400 Message-ID: <20100322132506.GA32521@think> References: <20100319180722.GC2314@localhost.localdomain> <20100322013304.GA30742@sli10-desk.sh.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Josef Bacik , "linux-btrfs@vger.kernel.org" To: Shaohua Li Return-path: In-Reply-To: <20100322013304.GA30742@sli10-desk.sh.intel.com> List-ID: On Mon, Mar 22, 2010 at 09:33:04AM +0800, Shaohua Li wrote: > On Sat, Mar 20, 2010 at 02:07:23AM +0800, Josef Bacik wrote: > > As Yan pointed out, theres not much reason for all this complicated math to > > account for file extents being split up into max_extent chunks, since they are > > likely to all end up in the same leaf anyway. Since there isn't much reason to > > use max_extent, just remove the option altogether so we have one less thing we > > need to test. Thanks, > Since we sometimes have very big extents like several hundered mega bytes, just > curious could removing max_extent limit cause more lock contentation for extent locks? The default for the max_extent option is (u64)-1. So, in general it was meant to force smaller extents as part of testing. -chris