From: Wengang Wang <wen.gang.wang@oracle.com>
To: Josef Bacik <josef@redhat.com>
Cc: Wengang Wang <wen.gang.wang@oracle.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] Btrfs: fix how we freeze
Date: Tue, 23 Mar 2010 23:25:18 +0800 [thread overview]
Message-ID: <20100323152518.GA2733@laptop.oracle.com> (raw)
In-Reply-To: <20100323150357.GE2381@localhost.localdomain>
On 10-03-23 11:03, Josef Bacik wrote:
> On Tue, Mar 23, 2010 at 10:54:08PM +0800, Wengang Wang wrote:
> > Hi,
> >
> > If the only thing is returning 0 in the freeze/unfreeze member functions, why
> > not just remove the two functions?
> >
>
> Because if the fs doesn't provide a freeze/unfreeze function, trying to do a
> freeze will return -EOPNOTSUPP, which is not what we want. Thanks,
How does freeze_fs()/unfreeze_fs() get called in btrfs? I think they
called by freeze_bdev()/unfreeze_fs() respectively. And I don't see
-EOPNOTSUPP is returned in the later two functions.
regards,
wengang.
next prev parent reply other threads:[~2010-03-23 15:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-23 14:28 [PATCH] Btrfs: fix how we freeze Josef Bacik
2010-03-23 14:54 ` Wengang Wang
2010-03-23 15:03 ` Josef Bacik
2010-03-23 15:25 ` Wengang Wang [this message]
2010-03-23 15:27 ` Josef Bacik
2010-03-23 15:39 ` Wengang Wang
2010-03-23 15:30 ` Wengang Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100323152518.GA2733@laptop.oracle.com \
--to=wen.gang.wang@oracle.com \
--cc=josef@redhat.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox