From: Chris Mason <chris.mason@oracle.com>
To: Alexander Beregalov <a.beregalov@gmail.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] Btrfs: fix unaligned access at btrfs_csum_final()
Date: Tue, 23 Mar 2010 11:34:20 -0400 [thread overview]
Message-ID: <20100323153420.GC30249@think> (raw)
In-Reply-To: <1269214268-1151-1-git-send-email-a.beregalov@gmail.com>
On Mon, Mar 22, 2010 at 02:31:08AM +0300, Alexander Beregalov wrote:
> Btrfs on Sparc64 produces a lot of warnings
> Kernel unaligned access at TPC[10148c84] btrfs_csum_final+0x44/0x60 [btrfs]
Great, thanks for trackign this down.
>
> It happens when btrfs_csum_final is called from write_dev_supers():
> 2195: btrfs_csum_final(crc, sb->csum);
>
> crc is u32, aligning sb->csum on 4-byte boundary fixes the problem.
So the size of the csum field is already 4 byte aligned, I'm surprised
we need this?
-chris
next prev parent reply other threads:[~2010-03-23 15:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-21 23:31 [PATCH] Btrfs: fix unaligned access at btrfs_csum_final() Alexander Beregalov
2010-03-23 15:34 ` Chris Mason [this message]
2010-03-24 0:51 ` Chris Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100323153420.GC30249@think \
--to=chris.mason@oracle.com \
--cc=a.beregalov@gmail.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox