linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chris Mason <chris.mason@oracle.com>
To: Miao Xie <miaox@cn.fujitsu.com>
Cc: Linux Btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH 01/18] btrfs: Remove u64 conversion for PAGE_CACHE_SIZE
Date: Thu, 25 Mar 2010 09:02:31 -0400	[thread overview]
Message-ID: <20100325130230.GG6538@think> (raw)
In-Reply-To: <4BAB56AE.5040009@cn.fujitsu.com>

On Thu, Mar 25, 2010 at 08:27:26PM +0800, Miao Xie wrote:
> From: Zhao Lei <zhaolei@cn.fujitsu.com>
> 
> We don't need to convert PAGE_CACHE_SIZE to u64 in bit operation.

For code like this:

u64 size = (some number that doesn't fit in 32 bits)

if (size & (PAGE_CACHE_SIZE - 1)) {
}

The answer should be the same either way.  But if the code gets
switched:

start = size & ~(PAGE_CACHE_SIZE - 1);

Some arches are going to get the wrong answer here.  We had a few bugs
like this early on and I went through and casted everything to be
consistent.  While this patch is correct, I would rather leave the casts
to avoid subtle problems later on as the code changes.

-chris


  reply	other threads:[~2010-03-25 13:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-25 12:27 [PATCH 01/18] btrfs: Remove u64 conversion for PAGE_CACHE_SIZE Miao Xie
2010-03-25 13:02 ` Chris Mason [this message]
2010-03-31  4:04   ` Zhaolei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100325130230.GG6538@think \
    --to=chris.mason@oracle.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=miaox@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).