From: Josef Bacik <josef@redhat.com>
To: Chris Mason <chris.mason@oracle.com>,
Josef Bacik <josef@redhat.com>,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] Btrfs: force delalloc flushing when things get desperate
Date: Tue, 30 Mar 2010 22:07:26 -0400 [thread overview]
Message-ID: <20100331020726.GD2352@localhost.localdomain> (raw)
In-Reply-To: <20100331012554.GU13190@think>
On Tue, Mar 30, 2010 at 09:25:54PM -0400, Chris Mason wrote:
> On Fri, Mar 12, 2010 at 04:23:09PM -0500, Josef Bacik wrote:
> > When testing with max_extents=4k, we enospc out really really early. The reason
> > for this is we really overwhelm the system with our worst case calculation.
> > When we try to flush delalloc, we don't want everybody to wait around forever,
> > so we wake up the waiters when we've done some of the work in hopes that its
> > enough work to get everything they need done. The problem with this is we don't
> > wait long enough sometimes. So if we've already done a flush_delalloc and
> > didn't find what we need, do it again and this time wait for the flushing to be
> > completely finished before returning. This makes my ENOSPC test actually
> > finish, instead of finishing in about 20 seconds. Thanks,
>
> Thanks Josef, was this one against the per-cpu work? It doesn't apply
> cleanly but is simple enough that I can just bang it in there ;)
>
Yeah I think it was, I can redo it if you like. It's not as big of a deal
without max_extent, but it could still be usefull for some corner cases.
Thanks,
Josef
prev parent reply other threads:[~2010-03-31 2:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-12 21:23 [PATCH] Btrfs: force delalloc flushing when things get desperate Josef Bacik
2010-03-31 1:25 ` Chris Mason
2010-03-31 2:07 ` Josef Bacik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100331020726.GD2352@localhost.localdomain \
--to=josef@redhat.com \
--cc=chris.mason@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).