linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nikanth Karthikesan <knikanth@suse.de>
To: Chris Mason <chris.mason@oracle.com>
Cc: linux-btrfs@vger.kernel.org, "Amit K. Arora" <aarora@linux.vnet.ibm.com>
Subject: [PATCH btrfs-unstable#master] Prevent creation of files larger than RLIMIT_FSIZE using fallocate
Date: Wed, 16 Jun 2010 14:00:53 +0530	[thread overview]
Message-ID: <201006161400.53879.knikanth@suse.de> (raw)

Hi Chris

I am resending this based on the btrfs-unstable tree. Please apply/reply.

Thanks
Nikanth

Prevent creation of files larger than RLIMIT_FSIZE using fallocate.

Currently using posix_fallocate one can bypass an RLIMIT_FSIZE limit
and create a larger file than the limit. Add a check for that.


Signed-off-by: Nikanth Karthikesan <knikanth@suse.de>
Cc: Amit K. Arora <aarora@linux.vnet.ibm.com>

---

diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
index f08427c..7870f4f 100644
--- a/fs/btrfs/inode.c
+++ b/fs/btrfs/inode.c
@@ -6842,6 +6842,11 @@ static long btrfs_fallocate(struct inode *inode, int mode,
 	btrfs_wait_ordered_range(inode, alloc_start, alloc_end - alloc_start);
 
 	mutex_lock(&inode->i_mutex);
+
+	ret = inode_newsize_ok(inode, (offset + len));
+	if (ret)
+		goto out;
+
 	if (alloc_start > inode->i_size) {
 		ret = btrfs_cont_expand(inode, alloc_start);
 		if (ret)

                 reply	other threads:[~2010-06-16  8:30 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201006161400.53879.knikanth@suse.de \
    --to=knikanth@suse.de \
    --cc=aarora@linux.vnet.ibm.com \
    --cc=chris.mason@oracle.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).